Well-known types are not mapped

[milux]

The documentation of this project states:

If the google.protobuf package is referenced, it is assumed to be a well-known type and is changed to reference pbandk.wkt.

However, this is not what we observe.
When I don't pass any extra options to the Gradle plugin, the result looks like this:

This causes class name clashes in the resulting Java application.

When I supply a mapping via option("kotlin_package_mapping=google.protobuf->pbandk.wkt"), it still generates JavaFeatures:

Can anybody explain me why this happens?
If I understand the documentation right, any well-known stuff from google.protobuf should come from the pbandk runtime and not result in generated code in the first place, right?

For reference:
We talk about a KMP (Kotlin Multi Platform) project and the protobuf config looks like this:

protobuf {
    protoc {
        artifact = "com.google.protobuf:protoc:${libs.versions.protobuf.get()}"
    }
    plugins {
        id("pbandk") {
            artifact = "pro.streem.pbandk:protoc-gen-pbandk-jvm:${libs.versions.pbandk.get()}:jvm8@jar"
        }
    }
    generateProtoTasks {
        ofSourceSet("main").forEach { task ->
            task.builtins {
                remove("java")
            }
            task.plugins {
                id("pbandk") {
                    option("kotlin_package_mapping=google.protobuf->pbandk.wkt")
                    // Publish the code generated by pbandk as part of the `:protobuf-codegen` project's
                    // `commonMain` source set. This allows other Kotlin Multiplatform subprojects to consume the
                    // pbandk-generated Kotlin code using a regular Gradle project dependency.
                    val outputDir = task.getOutputDir(this)
                    project.kotlin.sourceSets.commonMain.configure {
                        // `builtBy` ensures that Gradle will automatically run the `generateProto` task before trying
                        // to compile the generated Kotlin code
                        kotlin.srcDir(project.files(outputDir).builtBy(task))
                    }
                }
            }
        }
    }
}

Any hints or ideas how to fix this appreciated!

[garyp]

Can you please share the versions of protoc, pbandk, and the protobuf gradle plugin that you are using?

[garyp]

Also please share the gradle code for all of the dependencies you have declared in the gradle file that contains the above protobuf config. Include any top-level dependencies as well as dependencies declared inside the kotlin block.

[milux]

Can you please share the versions of protoc, pbandk, and the protobuf gradle plugin that you are using?

[versions]
protobuf = "4.30.2"
pbandk = "0.16.0"

[libraries]
protobuf-java = { group = "com.google.protobuf", name = "protobuf-java", version.ref = "protobuf" }
pbandk-runtime = { group = "pro.streem.pbandk", name = "pbandk-runtime", version.ref = "pbandk" }

[plugins]
protobuf = { id = "com.google.protobuf", version = "0.9.5" }

[milux]

Also please share the gradle code for all of the dependencies you have declared in the gradle file that contains the above protobuf config. Include any top-level dependencies as well as dependencies declared inside the kotlin block.

Top level:

dependencies {
    protobuf(libs.protobuf.java)
}

KMP config:

kotlin {
    sourceSets {
        commonMain {
            dependencies {
                ...
                implementation(libs.pbandk.runtime)
                ...
            }
        }
        ...
    }
}

Thanks for your assistance!
Anything specific I should look for or any idea that may point us in the right direction?

[garyp]

I suspect the problem is caused by that top-level protobuf(libs.protobuf.java) dependency. That will cause the protobuf Gradle plugin to add the proto files from that library to the list of proto files that get passed to pbandk for codegen. Is there a reason you're adding that dependency? I need to double-check the docs, but I think if you use a compileOnly dependency instead of a protobuf dependency (as seen here:
https://github.com/streem/pbandk/blob/master/examples/browser-js/lib-proto/build.gradle.kts) then it should fix your issue.

[milux]

I think if you use a compileOnly dependency instead of a protobuf dependency (as seen here: https://github.com/streem/pbandk/blob/master/examples/browser-js/lib-proto/build.gradle.kts) then it should fix your issue.

That's it! Thanks a lot! 🚀
Without the dependency, protoc refuses compilation with stderr: google/protobuf/timestamp.proto: File not found..
I thought that protobuf was the way to go and didn't see that it caused these issues and actually "overrides" the default pbandk behavior. Is this fact documented somewhere? Did I overlook it?