Please use GitHub's "linked issue" feature

[FloEdelmann]

This is mainly targeted towards @westnordost and @matkoniecz, but also everyone else opening PRs:

TL;DR

Please put fixes #2913 in the PR description, not the PR title.

Explanation:

You often include the issue reference in the PR title, e.g. #2914: "does not exist" enabled for more quests, fixes #2913.
This makes it clear for humans which issue this PR addresses.

GitHub however does only recognize this in the PR description: https://docs.github.com/en/issues/tracking-your-work-with-issues/creating-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

In comparison: e.g. #2872 has Fixes #1285 in the PR description, so the linked issue is recognized:

This enables some cool features:

• When the PR is merged, the issue is closed automatically.
  Right now, it's only auto-closed if the merge commit message also includes the fixes #2913 keyword.
• In the PR list, it shows that an issue is linked:
  
• In the issue list, it shows that a PR is linked:
  
• It allows searching for issues with / without a linked PR and vice-versa: https://docs.github.com/en/github/searching-for-information-on-github/searching-on-github/searching-issues-and-pull-requests#search-for-linked-issues-and-pull-requests
• In an issue, linked PRs are highlighted right in the header:
  

[westnordost]

🆗

[matkoniecz]

OK

I keep forgetting about this GitHub bug (and it seems that there is no way to report bugs to GitHub at all, in past using "contact GitHub" resulted in at least placebo response)

[Lee-Carre]

@matkoniecz

there is no way to report bugs to GitHub

There is: github/feedback.

[matkoniecz]

It seems that this bug was fixed in meantime! I was unable to reproduce it.

[FloEdelmann]

Would be okay to ask you (either the PR authors or the repo maintainers) to edit the descriptions of the following currently open PRs to include the link to the respective issue?

• PR Migration from Kotlin-android-extension -> viewBinding #2894 by @sumanabhi: fixes Migrate to View Binding (kotlin-android-extensions are deprecated) #2890
• PR add camera type quest #2856 by @Helium314: fixes Surveillance camera properties #87
• PR implements #2774 and allow tagging lane count without markings #2852 by @matkoniecz: fixes Add "no markings, clear lane count' #2774
• PR Repeat last answer for sidewalk/bicycle lane #2591 by @arrival-spring: fixes Repeat last answer for bicycle lane quests #2542

EDIT: Everything is linked now :)

[matkoniecz]

PR #2852 by @matkoniecz: fixes #2774

done though it is the smallest problem of that PR :)

[westnordost]

Oh, I thought you had access too. I think it would make sense. Especially if you find small things that can be enhanced etc., then you could just commit them if you don't need a review.

[rugk]

BTW you can nowadays also link issues manually afterwards i.e. after the PR is already created without editing the PR body or so. That's somewhat convenient at least:

See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-to-an-issue

[FloEdelmann]

I tried this now at two different PRs, but the search feature there is so bad that it doesn't let me find the relevant issues. So I resort back to editing the PR description.

[riQQ]

You can just put in the issue number (with or without a preceding #).

[FloEdelmann]

I tried that, too, but the issue I searched didn't show up in the search results.

[rugk]

Oh, this always worked for me. Of course you can only link issues of your own repo - okay, maybe that is different, but apart from that, it always worked. ANyway the syntax is there to stay, so this will always also work.

[riQQ]

I could reproduce FloEdelmann's issue but couldn't find a reason which issues are not linkable and why.