Skip to content

Commit 2f32520

Browse files
authored
Fix various typos and leftovers in the API Conversion Tool (#12176)
Signed-off-by: Jakub Scholz <www@scholzj.com>
1 parent 2b4a231 commit 2f32520

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

v1-api-conversion/src/main/java/io/strimzi/kafka/api/conversion/v1/cli/CrdUpgradeCommand.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
/**
2222
* Upgrades the API versions in CRDs to store the new v1 version only
2323
*/
24-
@CommandLine.Command(name = "crd-upgrade", aliases = {"crd"}, description = "Upgrades the Strimzi CRDs and CRs to use v1beta2 version")
24+
@CommandLine.Command(name = "crd-upgrade", aliases = {"crd"}, description = "Upgrades the Strimzi CRDs and CRs to use v1 version")
2525
public class CrdUpgradeCommand extends AbstractCommand {
2626
private KubernetesClient client;
2727

@@ -53,7 +53,7 @@ private void storeCrsUnderNewVersion() {
5353
}
5454

5555
/**
56-
* Changes the stored versions in the CRD spec to keep v1beta2 as stored and the other versions as served. This
56+
* Changes the stored versions in the CRD spec to keep v1 as stored and the other versions as served. This
5757
* method does the change to a single Strimzi CRD.
5858
*
5959
* @param kind Kind of the custom resource definition where the stored version should be changed
@@ -85,7 +85,7 @@ private void changeStoredVersionInSpecForKind(String kind) {
8585
}
8686

8787
/**
88-
* Changes the stored versions in the CRD spec to keep v1beta2 as stored and the other versions as served. This does
88+
* Changes the stored versions in the CRD spec to keep v1 as stored and the other versions as served. This does
8989
* the change for all Strimzi CRDs.
9090
*/
9191
private void changeStoredVersionInSpec() {
@@ -95,7 +95,7 @@ private void changeStoredVersionInSpec() {
9595
}
9696

9797
/**
98-
* Changes the stored versions in the CRD status to keep only v1beta2 for given Strimzi kind.
98+
* Changes the stored versions in the CRD status to keep only v1 for given Strimzi kind.
9999
*
100100
* @param kind Kind of the custom resource definition where the stored versions should be changed
101101
*/
@@ -121,7 +121,7 @@ private void changeStoredVersionInStatusForKind(String kind) {
121121
}
122122

123123
/**
124-
* Changes the stored versions in the CRD status to keep only v1beta2 there. This does the change for all Strimzi CRDs.
124+
* Changes the stored versions in the CRD status to keep only v1 there. This does the change for all Strimzi CRDs.
125125
*/
126126
private void changeStoredVersionInStatus() {
127127
for (String kind : STRIMZI_KINDS) {
@@ -142,17 +142,17 @@ public void run() {
142142
println("Checking that the CRDs are present and have the desired API versions.");
143143
Utils.checkCrdsHaveApiVersions(client, CRD_NAMES.values(), FROM_API_VERSION, TO_API_VERSION);
144144

145-
// Change the stored version in CRD spec to v1beta2
145+
// Change the stored version in CRD spec to v1
146146
println("Changing stored version in all Strimzi CRDs to " + TO_API_VERSION + ":");
147147
changeStoredVersionInSpec();
148148
println();
149149

150-
// "Touch" all resources to have them stored as v1beta2
150+
// "Touch" all resources to have them stored as v1
151151
println("Updating all Strimzi CRs to be stored under " + TO_API_VERSION + ":");
152152
storeCrsUnderNewVersion();
153153
println();
154154

155-
// Change the stored versions in CRDs to v1beta2
155+
// Change the stored versions in CRDs to v1
156156
println("Changing stored version in statuses of all Strimzi CRDs to " + TO_API_VERSION + ":");
157157
changeStoredVersionInStatus();
158158
}

0 commit comments

Comments
 (0)