Skip to content

Commit 513dcd5

Browse files
authored
[ST] Fix env vars in YAML installation of CO and create co-namespace correctly (#12186)
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
1 parent 35780b4 commit 513dcd5

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

systemtest/src/main/java/io/strimzi/systemtest/resources/operator/SetupClusterOperator.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
package io.strimzi.systemtest.resources.operator;
66

77
import io.fabric8.kubernetes.api.model.Namespace;
8-
import io.fabric8.kubernetes.api.model.NamespaceBuilder;
98
import io.skodjob.testframe.enums.InstallType;
109
import io.skodjob.testframe.installation.InstallationMethod;
1110
import io.skodjob.testframe.resources.KubeResourceManager;
1211
import io.strimzi.systemtest.Environment;
12+
import io.strimzi.systemtest.utils.kubeUtils.NamespaceUtils;
1313

1414
/**
1515
* Class for handling the installation of ClusterOperator.
@@ -127,12 +127,7 @@ public void createClusterOperatorNamespace() {
127127
}
128128
}
129129

130-
KubeResourceManager.get().createResourceWithWait(new NamespaceBuilder()
131-
.withNewMetadata()
132-
.withName(clusterOperatorConfiguration.getNamespaceName())
133-
.endMetadata()
134-
.build()
135-
);
130+
NamespaceUtils.createNamespaceAndPrepare(clusterOperatorConfiguration.getNamespaceName());
136131
}
137132

138133
/**

systemtest/src/main/java/io/strimzi/systemtest/resources/operator/YamlInstallation.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
import java.io.File;
4343
import java.util.Arrays;
4444
import java.util.Collections;
45+
import java.util.LinkedHashMap;
4546
import java.util.List;
4647
import java.util.Map;
4748
import java.util.function.Function;
@@ -397,7 +398,12 @@ public static void deployClusterOperator(ClusterOperatorConfiguration clusterOpe
397398

398399
// Map the current envVars list to Map for easier manipulation
399400
Map<String, EnvVar> envVarMap = envVars.stream()
400-
.collect(Collectors.toMap(EnvVar::getName, Function.identity()));
401+
.collect(Collectors.toMap(
402+
EnvVar::getName,
403+
Function.identity(),
404+
(existing, replacement) -> existing,
405+
LinkedHashMap::new
406+
));
401407

402408
// Adding custom evn vars specified by user in installation
403409
if (clusterOperatorConfiguration.getExtraEnvVars() != null) {

0 commit comments

Comments
 (0)