Skip to content

Commit bc4a4dc

Browse files
authored
Fix permanent KafkaBridge enableMetrics deprecation warning (#12024)
Signed-off-by: Jakub Scholz <www@scholzj.com>
1 parent 77ce2ba commit bc4a4dc

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

api/src/main/java/io/strimzi/api/kafka/model/bridge/KafkaBridgeSpec.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public class KafkaBridgeSpec extends Spec implements HasConfigurableLogging, Has
6161
private ResourceRequirements resources;
6262
private JvmOptions jvmOptions;
6363
private Logging logging;
64-
private boolean enableMetrics;
64+
private Boolean enableMetrics;
6565
private MetricsConfig metricsConfig;
6666
private Probe livenessProbe;
6767
private Probe readinessProbe;
@@ -90,11 +90,11 @@ public void setReplicas(int replicas) {
9090
@PresentInVersions("v1beta2")
9191
@JsonInclude(JsonInclude.Include.NON_DEFAULT)
9292
@Description("Enable the metrics for the Kafka Bridge. Default is false.")
93-
public boolean getEnableMetrics() {
93+
public Boolean getEnableMetrics() {
9494
return enableMetrics;
9595
}
9696

97-
public void setEnableMetrics(boolean enableMetrics) {
97+
public void setEnableMetrics(Boolean enableMetrics) {
9898
this.enableMetrics = enableMetrics;
9999
}
100100

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaBridgeCluster.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ public static KafkaBridgeCluster fromCrd(Reconciliation reconciliation,
203203
} else if (spec.getMetricsConfig() instanceof StrimziMetricsReporter) {
204204
result.metrics = new StrimziMetricsReporterModel(spec, DEFAULT_METRICS_ALLOW_LIST);
205205
} else {
206-
result.isLegacyMetricsConfigEnabled = spec.getEnableMetrics();
206+
result.isLegacyMetricsConfigEnabled = Boolean.TRUE.equals(spec.getEnableMetrics());
207207
}
208208

209209
result.setTls(spec.getTls() != null ? spec.getTls() : null);

0 commit comments

Comments
 (0)