OLM related improvements: RBAC, Downward API for annotation, etc. (#1363)

* OLM related improvements: RBAC, Downward API for annotation, etc.

* Update CHANGELOG

* Fix tests

Author: scholzj

Diff for: CHANGELOG.md

@@ -8,6 +8,8 @@
     * Resources for alert manager deployment and configuration
     * Alerting rules with alert examples from Kafka and Zookeeper metrics
 * Enrich configuration options for off cluster access
+* Support for watching all namespaces
+* Operator Lifecycle Manager integration
 
 ## 0.10.0
 

Diff for: cluster-operator/src/main/java/io/strimzi/operator/cluster/ClusterOperatorConfig.java

@@ -79,7 +79,7 @@ public static ClusterOperatorConfig fromMap(Map<String, String> map) {
         String namespacesList = map.get(ClusterOperatorConfig.STRIMZI_NAMESPACE);
         Set<String> namespaces;
         if (namespacesList == null || namespacesList.isEmpty()) {
-            throw new InvalidConfigurationException(ClusterOperatorConfig.STRIMZI_NAMESPACE + " cannot be null");
+            namespaces = Collections.singleton(AbstractWatchableResourceOperator.ANY_NAMESPACE);
         } else {
             if (namespacesList.trim().equals(AbstractWatchableResourceOperator.ANY_NAMESPACE)) {
                 namespaces = Collections.singleton(AbstractWatchableResourceOperator.ANY_NAMESPACE);

Diff for: cluster-operator/src/test/java/io/strimzi/operator/cluster/ClusterOperatorConfigTest.java

@@ -95,19 +95,19 @@ public void testListOfNamespacesWithSpaces() {
         assertEquals(new HashSet<>(asList("foo", "bar", "baz")), config.getNamespaces());
     }
 
-    @Test(expected = InvalidConfigurationException.class)
+    @Test
     public void testNoNamespace() {
-
         Map<String, String> envVars = new HashMap<>(ClusterOperatorConfigTest.envVars);
         envVars.remove(ClusterOperatorConfig.STRIMZI_NAMESPACE);
 
-        ClusterOperatorConfig.fromMap(envVars);
+        ClusterOperatorConfig config = ClusterOperatorConfig.fromMap(envVars);
+        assertEquals(new HashSet<>(asList("*")), config.getNamespaces());
     }
 
-    @Test(expected = InvalidConfigurationException.class)
+    @Test
     public void testEmptyEnvVars() {
-
-        ClusterOperatorConfig.fromMap(Collections.emptyMap());
+        ClusterOperatorConfig config = ClusterOperatorConfig.fromMap(Collections.emptyMap());
+        assertEquals(new HashSet<>(asList("*")), config.getNamespaces());
     }
 
     @Test

Diff for: documentation/book/proc-deploying-cluster-operator-kubernetes-to-watch-whole-cluster.adoc

@@ -6,7 +6,7 @@
 [id='deploying-cluster-operator-kubernetes-to-watch-whole-cluster-{context}']
 = Deploying the Cluster Operator to watch all namespaces
 
-You can configure the Cluster Operator to watch {OpenShiftName} resources across all {Namespaces} in your {ProductPlatformName} cluster. When running in this mode, the Cluster Operator automatically manages clusters in any new projects or namespaces that are created.
+You can configure the Cluster Operator to watch {ProductName} resources across all {Namespaces} in your {ProductPlatformName} cluster. When running in this mode, the Cluster Operator automatically manages clusters in any new projects or namespaces that are created.
 
 .Prerequisites
 

Diff for: documentation/book/ref-operators-cluster-operator-configuration.adoc

@@ -7,8 +7,9 @@
 
 The Cluster Operator can be configured through the following supported environment variables:
 
-`STRIMZI_NAMESPACE`:: Required. A comma-separated list of namespaces that the operator should
-operate in. The Cluster Operator deployment might use the link:https://kubernetes.io/docs/tasks/inject-data-application/downward-api-volume-expose-pod-information/#the-downward-api[{KubernetesName} Downward API^]
+`STRIMZI_NAMESPACE`:: A comma-separated list of {Namespaces} that the operator should operate in.
+When not set, set to empty string, or to `*` the cluster operator will operate in all {Namespaces}.
+The Cluster Operator deployment might use the link:https://kubernetes.io/docs/tasks/inject-data-application/downward-api-volume-expose-pod-information/#the-downward-api[{KubernetesName} Downward API^]
 to set this automatically to the namespace the Cluster Operator is deployed in. See the example below:
 +
 [source,yaml,options="nowrap"]