Skip to content

Commit d982b8f

Browse files
authored
Fixed KafkaAgent Javadoc (#12370)
Signed-off-by: Paolo Patierno <ppatierno@live.com>
1 parent 5619b22 commit d982b8f

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaReconciler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ private Future<Void> updateKafkaAutoRebalanceStatus(KafkaStatus kafkaStatus) {
288288
Set<Integer> addedBrokers = kafka.addedNodes().stream().filter(NodeRef::broker).map(NodeRef::nodeId).collect(Collectors.toSet());
289289

290290
// if added brokers list contains all desired, it's a newly created cluster so there are no actual scaled up brokers.
291-
// when added brokers list has fewer nodes than desired, it actually containes the new ones for scaling up
291+
// when added brokers list has fewer nodes than desired, it actually contains the new ones for scaling up
292292
Set<Integer> scaledUpBrokerNodes = addedBrokers.containsAll(desiredBrokers) ? Set.of() : addedBrokers;
293293

294294
KafkaRebalanceUtils.updateKafkaAutoRebalanceStatus(kafkaStatus, kafkaAutoRebalanceStatus, scaledUpBrokerNodes);
@@ -314,7 +314,7 @@ protected Future<Void> modelWarnings(KafkaStatus kafkaStatus) {
314314
/**
315315
* Initialize the TrustSet and PemAuthIdentity to be used by TLS clients during reconciliation
316316
*
317-
* @return Completes when the TrustStore and PemAuthIdentity have been created and stored in a record
317+
* @return Completes when the TrustSet and PemAuthIdentity have been created and stored in a record
318318
*/
319319
protected Future<Void> initClientAuthenticationCertificates() {
320320
return ReconcilerUtils.coTlsPemIdentity(reconciliation, secretOperator)

kafka-agent/src/main/java/io/strimzi/kafka/agent/KafkaAgent.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,10 @@ public class KafkaAgent {
8989
/**
9090
* Constructor of the KafkaAgent
9191
*
92-
* @param client Keystore containing the broker certificate
93-
* @param caCertSecretName Password for keystore
94-
* @param nodeCertSecretName Truststore containing CA certs for authenticating clients
95-
* @param namespace Password for truststore
92+
* @param client Kubernetes client instance
93+
* @param caCertSecretName CA certificate Secret name
94+
* @param nodeCertSecretName Node certificate Secret name
95+
* @param namespace Namespace where the Kafka cluster is running
9696
*/
9797
/* test */ KafkaAgent(KubernetesClient client, String caCertSecretName, String nodeCertSecretName, String namespace) {
9898
this.caCertSecret = getKubernetesSecret(client, caCertSecretName, namespace);
@@ -106,6 +106,8 @@ private Secret getKubernetesSecret(KubernetesClient client, String caCertSecretN
106106
/**
107107
* Constructor of the KafkaAgent
108108
*
109+
* @param caCertSecret CA certificate Secret
110+
* @param nodeCertSecret Node certificate Secret
109111
* @param brokerState Current state of the broker
110112
* @param remainingLogsToRecover Number of remaining logs to recover
111113
* @param remainingSegmentsToRecover Number of remaining segments to recover

0 commit comments

Comments
 (0)