Skip to content

Conversation

@tinaselenge
Copy link
Contributor

@tinaselenge tinaselenge commented Jan 27, 2026

Type of change

Select the type of your PR

  • Refactoring

Description

Removes Vertx from KafkaRoller, KafkaAvailability, KafkaQuorumCheck and their test classes.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 72.44094% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.74%. Comparing base (2d31a2b) to head (1ca131a).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...perator/cluster/operator/resource/KafkaRoller.java 62.50% 25 Missing and 5 partials ⚠️
...or/cluster/operator/resource/KafkaQuorumCheck.java 68.75% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12356      +/-   ##
============================================
- Coverage     75.00%   74.74%   -0.27%     
+ Complexity     6646     6645       -1     
============================================
  Files           373      373              
  Lines         25361    25418      +57     
  Branches       3404     3417      +13     
============================================
- Hits          19023    18999      -24     
- Misses         4949     5022      +73     
- Partials       1389     1397       +8     
Files with missing lines Coverage Δ
...erator/cluster/operator/assembly/CaReconciler.java 89.45% <100.00%> (-0.05%) ⬇️
...tor/cluster/operator/assembly/KafkaReconciler.java 94.60% <100.00%> (ø)
...r/cluster/operator/resource/KafkaAvailability.java 88.79% <100.00%> (+0.19%) ⬆️
...or/cluster/operator/resource/KafkaQuorumCheck.java 91.52% <68.75%> (-4.71%) ⬇️
...perator/cluster/operator/resource/KafkaRoller.java 60.69% <62.50%> (-16.70%) ⬇️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scholzj
Copy link
Member

scholzj commented Feb 1, 2026

/gha run pipeline=upgrade,regression

@scholzj scholzj added this to the 0.51.0 milestone Feb 1, 2026
@github-actions
Copy link

github-actions bot commented Feb 1, 2026

⏳ System test verification started: link

The following 10 job(s) will be executed:

  • regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
  • regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
  • regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)
  • upgrade-azp_kraft_upgrade-amd64 (oracle-vm-4cpu-16gb-x86-64)
  • upgrade-azp_kafka_upgrade-amd64 (oracle-vm-4cpu-16gb-x86-64)
  • upgrade-azp_kraft_upgrade-arm64 (oracle-vm-4cpu-16gb-arm64)
  • upgrade-azp_kafka_upgrade-arm64 (oracle-vm-4cpu-16gb-arm64)

Tests will start after successful build completion.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

❌ System test verification failed: link

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

🎉 System test verification passed: link

@tinaselenge tinaselenge requested a review from scholzj February 10, 2026 13:46
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more nits. LGTM otherwise.

@scholzj
Copy link
Member

scholzj commented Feb 10, 2026

/gha run pipeline=regression

@github-actions
Copy link

⏳ System test verification started: link
Waiting for build to finish...

@scholzj
Copy link
Member

scholzj commented Feb 10, 2026

@tinaselenge I triggers the STs. But then I realised that there is probably something wrong with the UT/ITs. There seem to be also many issues like this:

2026-02-10 18:48:31 INFO  KafkaRoller:359 - Reconciliation #991(initial-reconciliation) Kafka(testnoautorebalancingidlenoscaling/my-cluster): Will temporarily skip verifying pod my-cluster-controllers-10/10 is up-to-date due to java.lang.NullPointerException: Cannot invoke "org.apache.kafka.common.KafkaFuture.toCompletionStage()" because the return value of "java.util.Map.get(Object)" is null, retrying after at least 1000ms

I guess that could be some mocking issue.

Signed-off-by: Gantigmaa Selenge <[email protected]>
@scholzj
Copy link
Member

scholzj commented Feb 12, 2026

/gha run pipeline=regression

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

⏳ System test verification started: link

The following 6 job(s) will be executed:

  • regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
  • regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
  • regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)

Tests will start after successful build completion.

@github-actions
Copy link

🎉 System test verification passed: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants