-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Remove Vertx from KafkaRoller, KafkaAvailability and KafkaQuorumCheck #12356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
678e6e5 to
1ec2834
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12356 +/- ##
============================================
- Coverage 75.00% 74.74% -0.27%
+ Complexity 6646 6645 -1
============================================
Files 373 373
Lines 25361 25418 +57
Branches 3404 3417 +13
============================================
- Hits 19023 18999 -24
- Misses 4949 5022 +73
- Partials 1389 1397 +8
🚀 New features to boost your workflow:
|
Signed-off-by: Gantigmaa Selenge <[email protected]>
1ec2834 to
d451957
Compare
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/resource/KafkaRoller.java
Show resolved
Hide resolved
|
/gha run pipeline=upgrade,regression |
|
⏳ System test verification started: link The following 10 job(s) will be executed:
Tests will start after successful build completion. |
|
❌ System test verification failed: link |
|
🎉 System test verification passed: link |
Signed-off-by: Gantigmaa Selenge <[email protected]>
scholzj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more nits. LGTM otherwise.
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/CompletableFutureUtil.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/CompletableFutureUtil.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/CompletableFutureUtil.java
Outdated
Show resolved
Hide resolved
|
/gha run pipeline=regression |
|
⏳ System test verification started: link |
|
@tinaselenge I triggers the STs. But then I realised that there is probably something wrong with the UT/ITs. There seem to be also many issues like this: I guess that could be some mocking issue. |
Signed-off-by: Gantigmaa Selenge <[email protected]>
668160f to
1ca131a
Compare
|
/gha run pipeline=regression |
|
⏳ System test verification started: link The following 6 job(s) will be executed:
Tests will start after successful build completion. |
|
🎉 System test verification passed: link |
Type of change
Select the type of your PR
Description
Removes Vertx from KafkaRoller, KafkaAvailability, KafkaQuorumCheck and their test classes.
Checklist
Please go through this checklist and make sure all applicable tasks have been done