Added support for Bridge internal configuration#12598
Added support for Bridge internal configuration#12598ppatierno merged 5 commits intostrimzi:mainfrom
Conversation
Signed-off-by: Paolo Patierno <ppatierno@live.com>
|
⏳ System test verification started: link |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12598 +/- ##
============================================
+ Coverage 75.01% 75.02% +0.01%
- Complexity 6444 6450 +6
============================================
Files 374 375 +1
Lines 24924 24937 +13
Branches 3213 3214 +1
============================================
+ Hits 18697 18710 +13
- Misses 4901 4902 +1
+ Partials 1326 1325 -1
🚀 New features to boost your workflow:
|
|
❌ System test validation failed The provided pipeline/profile names did not match any configured tests. Available pipelines: Available profiles: Please check your command for typos and try again. |
|
/gha run profile=azp_bridge |
|
⏳ System test verification started: link |
|
❌ System test validation failed The provided pipeline/profile names did not match any configured tests. Available pipelines: Available profiles: Please check your command for typos and try again. |
|
/gha run groups=bridge |
|
⏳ System test verification started: link The following 1 job(s) will be executed:
Tests will start after successful build completion. |
|
❌ System test verification failed: link |
|
@im-konge AFAIU, you mentioned that the failing OLM tests are not related to this PR but because of kind setup. |
api/src/test/java/io/strimzi/api/kafka/model/bridge/KafkaBridgeCrdIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Signed-off-by: Paolo Patierno <ppatierno@live.com>
PaulRMellor
left a comment
There was a problem hiding this comment.
Thanks. I left a few suggestions.
api/src/main/java/io/strimzi/api/kafka/model/bridge/KafkaBridgeSpec.java
Show resolved
Hide resolved
documentation/modules/configuring/con-config-http-bridge-settings.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/con-config-http-bridge-settings.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/con-config-http-bridge-settings.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/con-config-http-bridge-settings.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/con-config-http-bridge-settings.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/con-config-http-bridge-settings.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/con-config-http-bridge-settings.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/con-config-http-bridge-settings.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Patierno <ppatierno@live.com>
|
/gha run pipeline=regression |
|
⏳ System test verification started: link The following 6 job(s) will be executed:
Tests will start after successful build completion. |
|
@im-konge do you have anything else to add to this PR? |
|
🎉 System test verification passed: link |
This PR implements SIP 134 by adding support for user-provided configuration to the
KafkaBridgecustom resource via a the newspec.configfield.This allows users to specify additional bridge-specific properties while filtering out forbidden properties that could conflict with operator-managed settings.
Currently the only supported configuration parameters are related to the internal executor service:
bridge.executor.pool.sizeandbridge.executor.queue.size.