[BUG] java.lang.IndexOutOfBoundsException: Index 9 out of bounds for length 9

[kirillzyusko]

Summary

App crashes when using react-native SDK + react-native-keyboard-controller.

Not sure why, but it seems like crash happens if you add addTextChangedListener to expiration date field 🤷‍♂ In this code: https://github.com/kirillzyusko/react-native-keyboard-controller/blob/f4eb08879e6c8f346d5a1c3935227252c4e96e20/android/src/main/java/com/reactnativekeyboardcontroller/extensions/EditText.kt#L24-L92

The try block produces IllegalArgumentException(because ReactEditText is not castable to Stripe input), so I simply call addTextChangedListener (I'm adding a listener when text-field gains a focus). When you finish entering expiration date then app instantly crashes with:

ERROR  Your app just crashed. See the error below.
java.lang.IndexOutOfBoundsException: Index 9 out of bounds for length 9
  jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
  jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
  jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)

I thought that maybe I'm dispatching a react event and because of that it breaks something, but turns out that if I add even empty handler, then exception still happens:

val listener =
    object : TextWatcher {
      @Suppress("detekt:EmptyFunctionBlock")
      override fun afterTextChanged(s: Editable?) = Unit

      @Suppress("detekt:EmptyFunctionBlock")
      override fun beforeTextChanged(
        s: CharSequence?,
        start: Int,
        count: Int,
        after: Int,
      ) = Unit

      override fun onTextChanged(
        s: CharSequence?,
        start: Int,
        before: Int,
        count: Int,
      ) {
        val currentText = s.toString()

        if (currentText != lastText) {
          lastText = currentText
          // action(currentText)
        }
      }

Code to reproduce

You can use this example: kirillzyusko/react-native-keyboard-controller#808

Field is located in AwareScrollView example.

Android version

Tested on API 35

Impacted devices

I believe all devices are impacted, but I tested only on simulator with API 35.

Installation method

As react-native SDK.

Dependency Versions

kotlin:
stripe-android:
Android Gradle Plugin:

Gradle:

Build time: 2024-09-23 21:28:39 UTC
Revision: 415adb9e06a516c44b391edff552fd42139443f7

Kotlin: 1.9.24
Groovy: 3.0.22
Ant: Apache Ant(TM) version 1.10.14 compiled on August 16 2023
Launcher JVM: 17.0.9 (Microsoft 17.0.9+8-LTS)
Daemon JVM: /Users/kirylziusko/.sdkman/candidates/java/17.0.9-ms (no JDK specified, using current Java home)
OS: Mac OS X 15.2 aarch64

SDK classes

🤷‍♂

Video

Screen.Recording.2025-02-14.at.16.29.37.mov

Other information

Maybe it's react-native SDK issue - if so, then can you transfer the issue to the corresponding repository?

Stacktrace

2025-02-14 16:29:39.342 22632-22632 AndroidRuntime          com...reactnativekeyboardcontroller  E  FATAL EXCEPTION: main (Ask Gemini)
                                                                                                    Process: com.example.reactnativekeyboardcontroller, PID: 22632
                                                                                                    java.lang.IndexOutOfBoundsException: Index 9 out of bounds for length 9
                                                                                                    	at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
                                                                                                    	at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
                                                                                                    	at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
                                                                                                    	at java.util.Objects.checkIndex(Objects.java:359)
                                                                                                    	at java.util.ArrayList.get(ArrayList.java:434)
                                                                                                    	at android.widget.TextView.sendAfterTextChanged(TextView.java:12745)
                                                                                                    	at android.widget.TextView$ChangeWatcher.afterTextChanged(TextView.java:16334)
                                                                                                    	at android.text.SpannableStringBuilder.sendAfterTextChanged(SpannableStringBuilder.java:1278)
                                                                                                    	at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:578)
                                                                                                    	at androidx.emoji2.text.SpannableBuilder.replace(SpannableBuilder.java:315)
                                                                                                    	at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:508)
                                                                                                    	at androidx.emoji2.text.SpannableBuilder.replace(SpannableBuilder.java:305)
                                                                                                    	at androidx.emoji2.text.SpannableBuilder.replace(SpannableBuilder.java:49)
                                                                                                    	at android.text.method.NumberKeyListener.onKeyDown(NumberKeyListener.java:129)
                                                                                                    	at android.widget.TextView.doKeyDown(TextView.java:9814)
                                                                                                    	at android.widget.TextView.onKeyDown(TextView.java:9569)
                                                                                                    	at android.view.KeyEvent.dispatch(KeyEvent.java:2966)
                                                                                                    	at android.view.View.dispatchKeyEvent(View.java:16379)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.widget.ScrollView.dispatchKeyEvent(ScrollView.java:513)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at com.facebook.react.ReactRootView.dispatchKeyEvent(ReactRootView.java:328)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1967)
                                                                                                    	at com.android.internal.policy.DecorView.superDispatchKeyEvent(DecorView.java:472)
                                                                                                    	at com.android.internal.policy.PhoneWindow.superDispatchKeyEvent(PhoneWindow.java:1955)
                                                                                                    	at android.app.Activity.dispatchKeyEvent(Activity.java:4479)
2025-02-14 16:29:39.343 22632-22632 AndroidRuntime          com...reactnativekeyboardcontroller  E  	at androidx.core.app.ComponentActivity.superDispatchKeyEvent(ComponentActivity.kt:103) (Ask Gemini)
                                                                                                    	at androidx.core.view.KeyEventDispatcher.dispatchKeyEvent(KeyEventDispatcher.java:85)
                                                                                                    	at androidx.core.app.ComponentActivity.dispatchKeyEvent(ComponentActivity.kt:117)
                                                                                                    	at androidx.appcompat.app.AppCompatActivity.dispatchKeyEvent(AppCompatActivity.java:604)
                                                                                                    	at androidx.appcompat.view.WindowCallbackWrapper.dispatchKeyEvent(WindowCallbackWrapper.java:60)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.dispatchKeyEvent(AppCompatDelegateImpl.java:3413)
                                                                                                    	at com.android.internal.policy.DecorView.dispatchKeyEvent(DecorView.java:386)
                                                                                                    	at android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent(ViewRootImpl.java:7714)
                                                                                                    	at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:7554)
                                                                                                    	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6955)
                                                                                                    	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:7012)
                                                                                                    	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6978)
                                                                                                    	at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:7144)
                                                                                                    	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6986)
                                                                                                    	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:7201)
                                                                                                    	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6959)
                                                                                                    	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:7012)
                                                                                                    	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6978)
                                                                                                    	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6986)
                                                                                                    	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6959)
                                                                                                    	at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:10080)
                                                                                                    	at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:10031)
                                                                                                    	at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:10000)
                                                                                                    	at android.view.ViewRootImpl$ViewRootHandler.handleMessageImpl(ViewRootImpl.java:6674)
                                                                                                    	at android.view.ViewRootImpl$ViewRootHandler.handleMessage(ViewRootImpl.java:6540)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:107)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:232)
                                                                                                    	at android.os.Looper.loop(Looper.java:317)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:8699)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:886)

[jaynewstrom-stripe]

I'm not able to repro this in our sample. I added your listener to our example, and tried it here: https://github.com/stripe/stripe-android/blob/b6ac6cc775ede2e74ec7aea86f403e1345135a1e/example/src/main/java/com/stripe/example/activity/CardBrandChoiceExampleActivity.kt#L93-L92

Via:

        var lastText: String? = null
        val listener =
            object : TextWatcher {
                @Suppress("detekt:EmptyFunctionBlock")
                override fun afterTextChanged(s: Editable?) = Unit

                @Suppress("detekt:EmptyFunctionBlock")
                override fun beforeTextChanged(
                    s: CharSequence?,
                    start: Int,
                    count: Int,
                    after: Int,
                ) = Unit

                override fun onTextChanged(
                    s: CharSequence?,
                    start: Int,
                    before: Int,
                    count: Int,
                ) {
                    val currentText = s.toString()

                    if (currentText != lastText) {
                        lastText = currentText
                        // action(currentText)
                    }
                }
            }
        viewBinding.cardMultilineWidget.setExpiryDateTextWatcher(listener)

Can you recreate this in the android (not react native) sample?

[kirillzyusko]

@jaynewstrom-stripe I've tried and I also can not re-create the problem 🤔

Can we transfer that issue to react-native SDK repository? Maybe the bug happens when we integrate react-native wrapper + keyboard-controller lib?..

[sajorahasan]

I am also facing this issue, here is the crashlog:

I haven't changed anything in last 2 months and it started giving me crashes just today as soon as I enter card expiry year in cardfield component of stripe.

2025-02-18 13:03:04.559  9835-9835  AndroidRuntime          com.timeofmylife.app                 E  FATAL EXCEPTION: main (Ask Gemini)
                                                                                                    Process: com.timeofmylife.app, PID: 9835
                                                                                                    java.lang.IndexOutOfBoundsException: Index 9 out of bounds for length 9
                                                                                                    	at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
                                                                                                    	at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
                                                                                                    	at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
                                                                                                    	at java.util.Objects.checkIndex(Objects.java:359)
                                                                                                    	at java.util.ArrayList.get(ArrayList.java:434)
                                                                                                    	at android.widget.TextView.sendAfterTextChanged(TextView.java:12749)
                                                                                                    	at android.widget.TextView$ChangeWatcher.afterTextChanged(TextView.java:16341)
                                                                                                    	at android.text.SpannableStringBuilder.sendAfterTextChanged(SpannableStringBuilder.java:1278)
                                                                                                    	at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:578)
                                                                                                    	at androidx.emoji2.text.SpannableBuilder.replace(SpannableBuilder.java:315)
                                                                                                    	at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:508)
                                                                                                    	at androidx.emoji2.text.SpannableBuilder.replace(SpannableBuilder.java:305)
                                                                                                    	at androidx.emoji2.text.SpannableBuilder.replace(SpannableBuilder.java:49)
                                                                                                    	at android.text.method.NumberKeyListener.onKeyDown(NumberKeyListener.java:129)
                                                                                                    	at android.widget.TextView.doKeyDown(TextView.java:9818)
                                                                                                    	at android.widget.TextView.onKeyDown(TextView.java:9573)
                                                                                                    	at android.view.KeyEvent.dispatch(KeyEvent.java:3029)
                                                                                                    	at android.view.View.dispatchKeyEvent(View.java:16351)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at com.facebook.react.ReactRootView.dispatchKeyEvent(ReactRootView.java:300)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1962)
                                                                                                    	at com.android.internal.policy.DecorView.superDispatchKeyEvent(DecorView.java:446)
                                                                                                    	at com.android.internal.policy.PhoneWindow.superDispatchKeyEvent(PhoneWindow.java:1970)
                                                                                                    	at android.app.Activity.dispatchKeyEvent(Activity.java:4491)
                                                                                                    	at androidx.core.app.ComponentActivity.superDispatchKeyEvent(ComponentActivity.kt:103)
                                                                                                    	at androidx.core.view.KeyEventDispatcher.dispatchKeyEvent(KeyEventDispatcher.java:85)
                                                                                                    	at androidx.core.app.ComponentActivity.dispatchKeyEvent(ComponentActivity.kt:117)
                                                                                                    	at androidx.appcompat.app.AppCompatActivity.dispatchKeyEvent(AppCompatActivity.java:604)
                                                                                                    	at androidx.appcompat.view.WindowCallbackWrapper.dispatchKeyEvent(WindowCallbackWrapper.java:60)
                                                                                                    	at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.dispatchKeyEvent(AppCompatDelegateImpl.java:3413)
2025-02-18 13:03:04.559  9835-9835  AndroidRuntime          com.timeofmylife.app                 E  	at com.android.internal.policy.DecorView.dispatchKeyEvent(DecorView.java:360) (Ask Gemini)
                                                                                                    	at android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent(ViewRootImpl.java:7866)
                                                                                                    	at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:7706)
                                                                                                    	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:7106)
                                                                                                    	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:7163)
                                                                                                    	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:7129)
                                                                                                    	at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:7295)
                                                                                                    	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:7137)
                                                                                                    	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:7352)
                                                                                                    	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:7110)
                                                                                                    	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:7163)
                                                                                                    	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:7129)
                                                                                                    	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:7137)
                                                                                                    	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:7110)
                                                                                                    	at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:10214)
                                                                                                    	at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:10165)
                                                                                                    	at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:10134)
                                                                                                    	at android.view.ViewRootImpl$ViewRootHandler.handleMessageImpl(ViewRootImpl.java:6804)
                                                                                                    	at android.view.ViewRootImpl$ViewRootHandler.handleMessage(ViewRootImpl.java:6683)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:107)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:232)
                                                                                                    	at android.os.Looper.loop(Looper.java:317)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:8705)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:886)

[jaynewstrom-stripe]

@kirillzyusko @sajorahasan could you try forcing the version of stripe-android to 20.52.2 and see if the issue still exists?

In your app/build.gradle:

configurations.all {
  resolutionStrategy {
    force("com.stripe:stripe-android:20.52.2")
  }
}

Does the issue still reproduce with that version?

[kirillzyusko]

@jaynewstrom-stripe no, it didn't help, but I got more info on reproduction.

Basically I have a global focus listener that tracks which view holds a focus and it adds a text-changed-listener on a new field and removes a listener from an old input. A pseudocode looks like:

OnGlobalFocusChangeListener { oldFocus, newFocus ->
      // unfocused or focus was changed
      if (newFocus == null || oldFocus != null) {
        lastFocusedInput?.removeTextChangedListener(textWatcher)
      }
      if (newFocus is EditText) {
        lastFocusedInput = newFocus
        textWatcher = newFocus.addOnTextChangedListener(textListener)
      }
    }

The key thing that I discovered is that I can add listener without any problems (i.e. single newFocus.addOnTextChangedListener(textListener) works well).

However if I try to remove the listener lastFocusedInput?.removeTextChangedListener(textWatcher) then I get a crash 🤔

When I debug the app I see, that last symbol is not getting typed yet in expiry date field, but I already get "focus changed" event (so I'm removing my listener).
Can this exception happen because of the fact, that you (stripe) modify text in TextWatcher *which may trigger subsequent onTextChanged and other events) and while this happens I remove my watcher and Android panics, because he doesn't expect, that amount of listeners is not matching across events? This is just an assumption, so curious to hear your thoughts and whether you can reproduce it in your example app 👀

Also in my code to add a TextWatcher I do addTextChangedListener, but in your case I see you call setExpiryDateTextWatcher (not sure if it affects anything, but decided to highlight that as well).

[cttsai-stripe]

@kirillzyusko thank you for the additional information. Your assumption makes sense - the crash occurs because TextView.sendAfterTextChanged is not concurrency safe. Specifically, attempting to remove TextWatchers during event dispatching will cause the app to crash.

However, I did not see any sign that we move the focus arbitrarily. This might be a React Native specific problem. Could you help clarify:

1. What specific user action triggers this crash?
2. What are the values of newFocus and oldFocus when crash?
3. Does this crash occur in both React Native and native Android implementations?

[kirillzyusko]

What specific user action triggers this crash?

User enters expiry date (without entering card number) - see the attached video in the issue description

What are the values of newFocus and oldFocus when crash?

newFocus -> com.stripe.android.view.CvcEditText{7c615e8 VFED..CL. .F...... 0,0-91,63 #7f0900d2 app:id/cvc_edit_text aid=1073741836}

oldFocus -> com.stripe.android.view.ExpiryDateEditText{3743401 VFED..CL. ......ID 0,0-183,63 #7f090124 app:id/expiry_date_edit_text aid=1073741835}

Does this crash occur in both React Native and native Android implementations?

Haven't tested native Android implementation, but crash happens in react-native in 100% cases 👀 I'll try to test Android project only tomorrow.

However, I did not see any sign that we move the focus arbitrarily.

I don't see that react-native manages the focus 🤔 My debugging tells me that focus management happens in CardInputWidget.kt:

expiryDateEditText.completionCallback = {
    cvcEditText.requestFocus()
    cardInputListener?.onExpirationComplete()
}

A workaround in my case is to remove listener asynchronously. But honestly I don't know which of the lib should manage it:

• should react-native-keyboard-controller remove the listener on loosing a focus asynchronously?
• should stripe SDK request focus after all TextWatcher manipulations?

[cttsai-stripe]

It seems the crash occurs through the following steps:

1. The user finishes entering a valid expiration date
2. ExpiryDateEditText starts dispatching events through TextView.sendAfterTextChanged()
3. StripeTextWatcher.afterTextChanged() sets focus on cvcEditText through completionCallback()
4. react-native-keyboard-controller removes its TextWatcher as the focus changes
5. The TextWatcher list size changes while it is still being iterated, causing IndexOutOfBoundsException

Relevant code where the exception occurs:

void sendAfterTextChanged(Editable text) {
    if (mListeners != null) {
        final ArrayList<TextWatcher> list = mListeners;
        final int count = list.size();
        for (int i = 0; i < count; i++) {
            list.get(i).afterTextChanged(text);
        }
    }

    notifyListeningManagersAfterTextChanged();

    hideErrorIfUnchanged();
}

Since Android doesn't provide an API to detect when sendAfterTextChanged completes its execution, I suggest that react-native-keyboard-controller should be modified to prevent listener removal while events are still being dispatched.

@jaynewstrom-stripe what is your thought on this?

[jaynewstrom-stripe]

Another potential option would be for stripe to request focus after posting to the main thread. Although, I'd probably suggest both attempt to mitigate the issue.

Something like:

post {
    cvcEditText.requestFocus()
}

Which will delay running that code until the end of the run loop.

[kirillzyusko]

@jaynewstrom-stripe so do you think that it should be fixed in stripe SDK?

I already opened a PR in keyboard-controller: kirillzyusko/react-native-keyboard-controller#815 and it fixes the problem

But for me it looks like we both are doing what's allowed (I remove a listener, you set a focus), but when these changes are bundled together it causes a crash 🙈 So what I'm trying to understand is what is the best place to fix this problem? Stripe SDK/keyboard-controller/both?

[cttsai-stripe]

Another potential option would be for stripe to request focus after posting to the main thread. Although, I'd probably suggest both attempt to mitigate the issue.

Since this is a framework-level race condition, both components should ideally handle it defensively.

[kirillzyusko]

@cttsai-stripe makes sense! I'm merging a fix in react-native-keyboard-controller 🙌

Do you want me to close that issue or you'd like to use it as a reference for your PR and automatically close it when PR gets merged?