Remove unused code

Author: tillh-stripe

StripeFinancialConnections/StripeFinancialConnections/Source/Native/NativeFlowController.swift

@@ -1067,7 +1067,7 @@ extension NativeFlowController: NetworkingLinkLoginWarmupViewControllerDelegate
     ) {
         showTerminalError(error)
     }
-    
+
     func networkingLinkLoginWarmupViewControllerDidFailAttestationVerdict(
         _ viewController: NetworkingLinkLoginWarmupViewController,
         prefillDetails: WebPrefillDetails
@@ -1134,10 +1134,6 @@ extension NativeFlowController: AttachLinkedPaymentAccountViewControllerDelegate
 // MARK: - NetworkingLinkVerificationViewControllerDelegate
 
 extension NativeFlowController: NetworkingLinkVerificationViewControllerDelegate {
-    func networkingLinkVerificationViewController(_ viewController: NetworkingLinkVerificationViewController, didReceiveConsumerPublishableKey consumerPublishableKey: String) {
-        dataManager.consumerPublishableKey = consumerPublishableKey
-    }
-
     func networkingLinkVerificationViewController(
         _ viewController: NetworkingLinkVerificationViewController,
         didRequestNextPane nextPane: FinancialConnectionsSessionManifest.NextPane,
@@ -1154,17 +1150,6 @@ extension NativeFlowController: NetworkingLinkVerificationViewControllerDelegate
     ) {
         showTerminalError(error)
     }
-
-    func networkingLinkVerificationViewControllerDidFailAttestationVerdict(
-        _ viewController: NetworkingLinkVerificationViewController,
-        prefillDetails: WebPrefillDetails
-    ) {
-        delegate?.nativeFlowController(
-            self,
-            shouldLaunchWebFlow: dataManager.manifest,
-            prefillDetails: prefillDetails
-        )
-    }
 }
 
 // MARK: - LinkAccountPickerViewControllerDelegate
@@ -1234,10 +1219,6 @@ extension NativeFlowController: LinkAccountPickerViewControllerDelegate {
 
 extension NativeFlowController: NetworkingSaveToLinkVerificationViewControllerDelegate {
 
-    func networkingSaveToLinkVerificationViewController(_ viewController: NetworkingSaveToLinkVerificationViewController, didReceiveConsumerPublishableKey consumerPublishableKey: String) {
-        dataManager.consumerPublishableKey = consumerPublishableKey
-    }
-
     func networkingSaveToLinkVerificationViewControllerDidFinish(
         _ viewController: NetworkingSaveToLinkVerificationViewController,
         saveToLinkWithStripeSucceeded: Bool?,
@@ -1256,27 +1237,12 @@ extension NativeFlowController: NetworkingSaveToLinkVerificationViewControllerDe
     ) {
         showTerminalError(error)
     }
-
-    func networkingSaveToLinkVerificationViewControllerDidFailAttestationVerdict(
-        _ viewController: NetworkingSaveToLinkVerificationViewController,
-        prefillDetails: WebPrefillDetails
-    ) {
-        delegate?.nativeFlowController(
-            self,
-            shouldLaunchWebFlow: dataManager.manifest,
-            prefillDetails: prefillDetails
-        )
-    }
 }
 
 // MARK: - NetworkingLinkStepUpVerificationViewControllerDelegate
 
 extension NativeFlowController: NetworkingLinkStepUpVerificationViewControllerDelegate {
 
-    func networkingLinkStepUpVerificationViewController(_ viewController: NetworkingLinkStepUpVerificationViewController, didReceiveConsumerPublishableKey consumerPublishableKey: String) {
-        dataManager.consumerPublishableKey = consumerPublishableKey
-    }
-
     func networkingLinkStepUpVerificationViewController(
         _ viewController: NetworkingLinkStepUpVerificationViewController,
         didCompleteVerificationWithInstitution institution: FinancialConnectionsInstitution?,
@@ -1296,23 +1262,6 @@ extension NativeFlowController: NetworkingLinkStepUpVerificationViewControllerDe
     ) {
         showTerminalError(error)
     }
-
-    func networkingLinkStepUpVerificationViewControllerEncounteredSoftError(
-        _ viewController: NetworkingLinkStepUpVerificationViewController
-    ) {
-        pushPane(.institutionPicker, animated: true)
-    }
-
-    func networkingLinkStepUpVerificationViewControllerDidFailAttestationVerdict(
-        _ viewController: NetworkingLinkStepUpVerificationViewController,
-        prefillDetails: WebPrefillDetails
-    ) {
-        delegate?.nativeFlowController(
-            self,
-            shouldLaunchWebFlow: dataManager.manifest,
-            prefillDetails: prefillDetails
-        )
-    }
 }
 
 // MARK: - LinkLoginViewControllerDelegate
@@ -1679,8 +1628,7 @@ private func CreatePaneViewController(
             clientSecret: dataManager.clientSecret,
             analyticsClient: dataManager.analyticsClient,
             nextPaneOrDrawerOnSecondaryCta: parameters?.nextPaneOrDrawerOnSecondaryCta,
-            elementsSessionContext: dataManager.elementsSessionContext,
-            consumerSession: dataManager.consumerSession
+            elementsSessionContext: dataManager.elementsSessionContext
         )
         let networkingLinkWarmupViewController = NetworkingLinkLoginWarmupViewController(
             dataSource: networkingLinkWarmupDataSource,

StripeFinancialConnections/StripeFinancialConnections/Source/Native/NetworkingLinkLoginWarmup/NetworkingLinkLoginWarmupDataSource.swift

@@ -29,7 +29,6 @@ final class NetworkingLinkLoginWarmupDataSourceImplementation: NetworkingLinkLog
     let analyticsClient: FinancialConnectionsAnalyticsClient
     private let nextPaneOrDrawerOnSecondaryCta: String?
     private let elementsSessionContext: ElementsSessionContext?
-    private let consumerSession: ConsumerSessionData?
 
     var email: String? {
         manifest.accountholderCustomerEmailAddress ?? elementsSessionContext?.prefillDetails?.email
@@ -41,16 +40,14 @@ final class NetworkingLinkLoginWarmupDataSourceImplementation: NetworkingLinkLog
         clientSecret: String,
         analyticsClient: FinancialConnectionsAnalyticsClient,
         nextPaneOrDrawerOnSecondaryCta: String?,
-        elementsSessionContext: ElementsSessionContext?,
-        consumerSession: ConsumerSessionData?
+        elementsSessionContext: ElementsSessionContext?
     ) {
         self.manifest = manifest
         self.apiClient = apiClient
         self.clientSecret = clientSecret
         self.analyticsClient = analyticsClient
         self.nextPaneOrDrawerOnSecondaryCta = nextPaneOrDrawerOnSecondaryCta
         self.elementsSessionContext = elementsSessionContext
-        self.consumerSession = consumerSession
     }
 
     func lookupConsumerSession() -> Future<LookupConsumerSessionResponse> {
@@ -80,7 +77,7 @@ final class NetworkingLinkLoginWarmupDataSourceImplementation: NetworkingLinkLog
             clientSecret: clientSecret
         )
     }
-    
+
     // Marks the assertion as completed and logs possible errors during verified flows.
     func completeAssertionIfNeeded(
         possibleError: Error?,

StripeFinancialConnections/StripeFinancialConnections/Source/Native/NetworkingLinkLoginWarmup/NetworkingLinkLoginWarmupViewController.swift

@@ -39,7 +39,7 @@ final class NetworkingLinkLoginWarmupViewController: SheetViewController {
 
     private let dataSource: NetworkingLinkLoginWarmupDataSource
     weak var delegate: NetworkingLinkLoginWarmupViewControllerDelegate?
-    
+
     private lazy var warmupFooterView: NetworkingLinkLoginWarmupFooterView = {
         let secondaryButtonTitle: String
         if dataSource.manifest.isProductInstantDebits {
@@ -88,7 +88,6 @@ final class NetworkingLinkLoginWarmupViewController: SheetViewController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-
         setup(
             withContentView: PaneLayoutView.createContentView(
                 iconView: RoundedIconView(
@@ -118,14 +117,14 @@ final class NetworkingLinkLoginWarmupViewController: SheetViewController {
             eventName: "click.continue",
             pane: .networkingLinkLoginWarmup
         )
-        
+
         warmupFooterView.primaryButton?.isLoading = true
 
         dataSource
             .lookupConsumerSession()
             .observe { [weak self] result in
                 guard let self else { return }
-                
+
                 warmupFooterView.primaryButton?.isLoading = false
 
                 let attestationError = self.dataSource.completeAssertionIfNeeded(

StripeFinancialConnections/StripeFinancialConnections/Source/Native/NetworkingLinkStepUpVerification/NetworkingLinkStepUpVerificationDataSource.swift

@@ -50,7 +50,6 @@ final class NetworkingLinkStepUpVerificationDataSourceImplementation: Networking
             pane: .networkingLinkStepUpVerification,
             consumerSession: consumerSession,
             apiClient: apiClient,
-            clientSecret: clientSecret,
             analyticsClient: analyticsClient
         )
         self.networkingOTPDataSource = networkingOTPDataSource

StripeFinancialConnections/StripeFinancialConnections/Source/Native/NetworkingLinkStepUpVerification/NetworkingLinkStepUpVerificationViewController.swift

@@ -11,10 +11,6 @@ import Foundation
 import UIKit
 
 protocol NetworkingLinkStepUpVerificationViewControllerDelegate: AnyObject {
-    func networkingLinkStepUpVerificationViewController(
-        _ viewController: NetworkingLinkStepUpVerificationViewController,
-        didReceiveConsumerPublishableKey consumerPublishableKey: String
-    )
     func networkingLinkStepUpVerificationViewController(
         _ viewController: NetworkingLinkStepUpVerificationViewController,
         didCompleteVerificationWithInstitution institution: FinancialConnectionsInstitution?,
@@ -26,13 +22,6 @@ protocol NetworkingLinkStepUpVerificationViewControllerDelegate: AnyObject {
         _ viewController: NetworkingLinkStepUpVerificationViewController,
         didReceiveTerminalError error: Error
     )
-    func networkingLinkStepUpVerificationViewControllerEncounteredSoftError(
-        _ viewController: NetworkingLinkStepUpVerificationViewController
-    )
-    func networkingLinkStepUpVerificationViewControllerDidFailAttestationVerdict(
-        _ viewController: NetworkingLinkStepUpVerificationViewController,
-        prefillDetails: WebPrefillDetails
-    )
 }
 
 final class NetworkingLinkStepUpVerificationViewController: UIViewController {

StripeFinancialConnections/StripeFinancialConnections/Source/Native/NetworkingLinkVerification/NetworkingLinkVerificationDataSource.swift

@@ -56,7 +56,6 @@ final class NetworkingLinkVerificationDataSourceImplementation: NetworkingLinkVe
             pane: .networkingLinkVerification,
             consumerSession: consumerSession,
             apiClient: apiClient,
-            clientSecret: clientSecret,
             analyticsClient: analyticsClient
         )
         self.networkingOTPDataSource = networkingOTPDataSource

StripeFinancialConnections/StripeFinancialConnections/Source/Native/NetworkingLinkVerification/NetworkingLinkVerificationViewController.swift

@@ -11,10 +11,6 @@ import Foundation
 import UIKit
 
 protocol NetworkingLinkVerificationViewControllerDelegate: AnyObject {
-    func networkingLinkVerificationViewController(
-        _ viewController: NetworkingLinkVerificationViewController,
-        didReceiveConsumerPublishableKey consumerPublishableKey: String
-    )
     func networkingLinkVerificationViewController(
         _ viewController: NetworkingLinkVerificationViewController,
         didRequestNextPane nextPane: FinancialConnectionsSessionManifest.NextPane,
@@ -25,10 +21,6 @@ protocol NetworkingLinkVerificationViewControllerDelegate: AnyObject {
         _ viewController: NetworkingLinkVerificationViewController,
         didReceiveTerminalError error: Error
     )
-    func networkingLinkVerificationViewControllerDidFailAttestationVerdict(
-        _ viewController: NetworkingLinkVerificationViewController,
-        prefillDetails: WebPrefillDetails
-    )
 }
 
 final class NetworkingLinkVerificationViewController: UIViewController {

StripeFinancialConnections/StripeFinancialConnections/Source/Native/NetworkingSaveToLinkVerification/NetworkingSaveToLinkVerificationDataSource.swift

@@ -50,7 +50,6 @@ final class NetworkingSaveToLinkVerificationDataSourceImplementation: Networking
             pane: .networkingSaveToLinkVerification,
             consumerSession: consumerSession,
             apiClient: apiClient,
-            clientSecret: clientSecret,
             analyticsClient: analyticsClient
         )
         self.networkingOTPDataSource = networkingOTPDataSource

StripeFinancialConnections/StripeFinancialConnections/Source/Native/NetworkingSaveToLinkVerification/NetworkingSaveToLinkVerificationViewController.swift

@@ -11,10 +11,6 @@ import Foundation
 import UIKit
 
 protocol NetworkingSaveToLinkVerificationViewControllerDelegate: AnyObject {
-    func networkingSaveToLinkVerificationViewController(
-        _ viewController: NetworkingSaveToLinkVerificationViewController,
-        didReceiveConsumerPublishableKey consumerPublishableKey: String
-    )
     func networkingSaveToLinkVerificationViewControllerDidFinish(
         _ viewController: NetworkingSaveToLinkVerificationViewController,
         saveToLinkWithStripeSucceeded: Bool?,
@@ -24,11 +20,6 @@ protocol NetworkingSaveToLinkVerificationViewControllerDelegate: AnyObject {
         _ viewController: NetworkingSaveToLinkVerificationViewController,
         didReceiveTerminalError error: Error
     )
-
-    func networkingSaveToLinkVerificationViewControllerDidFailAttestationVerdict(
-        _ viewController: NetworkingSaveToLinkVerificationViewController,
-        prefillDetails: WebPrefillDetails
-    )
 }
 
 final class NetworkingSaveToLinkVerificationViewController: UIViewController {

StripeFinancialConnections/StripeFinancialConnections/Source/Native/Shared/NetworkingOTPView/NetworkingOTPDataSource.swift

@@ -18,14 +18,9 @@ protocol NetworkingOTPDataSource: AnyObject {
     var isTestMode: Bool { get }
     var appearance: FinancialConnectionsAppearance { get }
     var pane: FinancialConnectionsSessionManifest.NextPane { get }
-    var emailAddress: String { get }
 
     func startVerificationSession() -> Future<ConsumerSessionResponse>
     func confirmVerificationSession(otpCode: String) -> Future<ConsumerSessionResponse>
-    func completeAssertionIfNeeded(
-        possibleError: Error?,
-        api: FinancialConnectionsAPIClientLogger.API
-    ) -> Error?
 }
 
 final class NetworkingOTPDataSourceImplementation: NetworkingOTPDataSource {
@@ -37,7 +32,6 @@ final class NetworkingOTPDataSourceImplementation: NetworkingOTPDataSource {
     private let connectionsMerchantName: String?
     private let apiClient: any FinancialConnectionsAPI
     private let manifest: FinancialConnectionsSessionManifest
-    private let clientSecret: String
     weak var delegate: NetworkingOTPDataSourceDelegate?
 
     private var consumerSession: ConsumerSessionData {
@@ -53,10 +47,6 @@ final class NetworkingOTPDataSourceImplementation: NetworkingOTPDataSource {
     var appearance: FinancialConnectionsAppearance {
         manifest.appearance
     }
-    
-    var emailAddress: String {
-        consumerSession.emailAddress
-    }
 
     init(
         otpType: String,
@@ -66,7 +56,6 @@ final class NetworkingOTPDataSourceImplementation: NetworkingOTPDataSource {
         pane: FinancialConnectionsSessionManifest.NextPane,
         consumerSession: ConsumerSessionData,
         apiClient: any FinancialConnectionsAPI,
-        clientSecret: String,
         analyticsClient: FinancialConnectionsAnalyticsClient
     ) {
         self.otpType = otpType
@@ -76,7 +65,6 @@ final class NetworkingOTPDataSourceImplementation: NetworkingOTPDataSource {
         self.pane = pane
         self.consumerSession = consumerSession
         self.apiClient = apiClient
-        self.clientSecret = clientSecret
         self.analyticsClient = analyticsClient
     }
 
@@ -102,18 +90,4 @@ final class NetworkingOTPDataSourceImplementation: NetworkingOTPDataSource {
             return Promise(value: consumerSessionResponse)
         }
     }
-
-    // Marks the assertion as completed and logs possible errors during verified flows.
-    func completeAssertionIfNeeded(
-        possibleError: Error?,
-        api: FinancialConnectionsAPIClientLogger.API
-    ) -> Error? {
-        guard manifest.verified else { return nil }
-        return apiClient.completeAssertion(
-            possibleError: possibleError,
-            api: api,
-            pane: pane
-        )
-    }
-
 }

StripeFinancialConnections/StripeFinancialConnections/Source/Native/Shared/NetworkingOTPView/NetworkingOTPView.swift

@@ -150,8 +150,6 @@ final class NetworkingOTPView: UIView {
         }
     }
 
-    // TODO: Where should we move the attestation error handling?
-
     func startVerification() {
         delegate?.networkingOTPViewWillStartVerification(self)
         dataSource.startVerificationSession()
@@ -259,7 +257,6 @@ private struct NetowrkingOTPViewRepresentable: UIViewRepresentable {
                 verificationSessions: []
             ),
             apiClient: FinancialConnectionsAPIClient(apiClient: .shared),
-            clientSecret: "",
             analyticsClient: FinancialConnectionsAnalyticsClient()
         ))
     }