Skip to content

Commit 5c17e2e

Browse files
Trim event API version when matching (#1727)
* Trim event API version when matching * remove bad assert
1 parent 8ffb825 commit 5c17e2e

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

src/main/java/com/stripe/model/EventDataObjectDeserializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ private boolean apiVersionMatch() {
195195
// Trim the locally configured API version to not include beta headers, since the payload won't
196196
// have any.
197197
String localApiVersion = StringUtils.trimApiVersion(Stripe.stripeVersion);
198-
return localApiVersion.equals(this.apiVersion);
198+
return localApiVersion.equals(StringUtils.trimApiVersion(this.apiVersion));
199199
}
200200

201201
/**

src/test/java/com/stripe/model/EventDataObjectDeserializerTest.java

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ public void testFailureOnApiVersionMisMatch() throws Exception {
143143
}
144144

145145
@Test
146-
public void testIgnoresBetaHeadersWhenDeterminingMatch() throws Exception {
146+
public void testIgnoresBetaHeadersInLibraryVersionWhenDeterminingMatch() throws Exception {
147147
final String data = getCurrentEventStringFixture();
148148
final Event event = ApiResource.GSON.fromJson(data, Event.class);
149149

@@ -156,6 +156,19 @@ public void testIgnoresBetaHeadersWhenDeterminingMatch() throws Exception {
156156
verifyDeserializedStripeObject(deserializer.getObject().get());
157157
}
158158

159+
@Test
160+
public void testIgnoresBetaHeadersInEventVersionWhenDeterminingMatch() throws Exception {
161+
final String data = getCurrentEventStringFixture();
162+
final Event event = ApiResource.GSON.fromJson(data, Event.class);
163+
event.apiVersion = CURRENT_EVENT_VERSION + "; some_beta=v1; some_beta=v2";
164+
165+
Stripe.stripeVersion = CURRENT_EVENT_VERSION;
166+
EventDataObjectDeserializer deserializer = event.getDataObjectDeserializer();
167+
168+
assertTrue(deserializer.getObject().isPresent());
169+
verifyDeserializedStripeObject(deserializer.getObject().get());
170+
}
171+
159172
@Test
160173
public void testApiVersionMismatchReportedEvenWhenBetaHeadersPresent() throws Exception {
161174
final String data = getCurrentEventStringFixture();

0 commit comments

Comments
 (0)