add safety to verifyMicrodeposits method

Author: charliecruzan-stripe

android/src/main/java/com/reactnativestripesdk/StripeSdkModule.kt

@@ -57,7 +57,7 @@ class StripeSdkModule(private val reactContext: ReactApplicationContext) : React
 
   private val mActivityEventListener = object : BaseActivityEventListener() {
     override fun onActivityResult(activity: Activity, requestCode: Int, resultCode: Int, data: Intent?) {
-      if (::stripe.isInitialized) {
+      if (stripe != null) {
         paymentSheetFragment?.activity?.activityResultRegistry?.dispatchResult(requestCode, resultCode, data)
         googlePayFragment?.activity?.activityResultRegistry?.dispatchResult(requestCode, resultCode, data)
         try {
@@ -530,8 +530,8 @@ class StripeSdkModule(private val reactContext: ReactApplicationContext) : React
   @ReactMethod
   fun retrievePaymentIntent(clientSecret: String, promise: Promise) {
     CoroutineScope(Dispatchers.IO).launch {
-      stripe?.let {
-        val paymentIntent = it.retrievePaymentIntentSynchronous(clientSecret)
+      stripe?.let { stripe ->
+        val paymentIntent = stripe.retrievePaymentIntentSynchronous(clientSecret)
         paymentIntent?.let {
           promise.resolve(createResult("paymentIntent", mapFromPaymentIntentResult(it)))
         } ?: run {
@@ -546,8 +546,8 @@ class StripeSdkModule(private val reactContext: ReactApplicationContext) : React
   @ReactMethod
   fun retrieveSetupIntent(clientSecret: String, promise: Promise) {
     CoroutineScope(Dispatchers.IO).launch {
-      stripe?.let {
-        val setupIntent = it.retrieveSetupIntentSynchronous(clientSecret)
+      stripe?.let { stripe ->
+        val setupIntent = stripe.retrieveSetupIntentSynchronous(clientSecret)
         setupIntent?.let {
           promise.resolve(createResult("setupIntent", mapFromSetupIntentResult(it)))
         } ?: run {
@@ -686,6 +686,10 @@ class StripeSdkModule(private val reactContext: ReactApplicationContext) : React
 
   @ReactMethod
   fun verifyMicrodeposits(isPaymentIntent: Boolean, clientSecret: String, params: ReadableMap, promise: Promise) {
+    val stripe = stripe ?: run {
+      promise.resolve(MISSING_INIT_ERROR)
+      return
+    }
     val amounts = params.getArray("amounts")
     val descriptorCode = params.getString("descriptorCode")
 

ios/StripeSdk.swift

@@ -936,6 +936,11 @@ class StripeSdk: RCTEventEmitter, STPApplePayContextDelegate, STPBankSelectionVi
         resolver resolve: @escaping RCTPromiseResolveBlock,
         rejecter reject: @escaping RCTPromiseRejectBlock
     ) -> Void {
+        guard let apiClient = apiClient else {
+            resolve(StripeSdk.MISSING_INIT_ERROR)
+            return
+        }
+        
         let amounts = params["amounts"] as? NSArray
         let descriptorCode = params["descriptorCode"] as? String
 
@@ -950,14 +955,14 @@ class StripeSdk: RCTEventEmitter, STPApplePayContextDelegate, STPBankSelectionVi
                 return
             }
             if (isPaymentIntent) {
-                STPAPIClient.shared.verifyPaymentIntentWithMicrodeposits(
+                apiClient.verifyPaymentIntentWithMicrodeposits(
                     clientSecret: clientSecret as String,
                     firstAmount: amounts[0] as! Int,
                     secondAmount: amounts[1] as! Int,
                     completion: onCompletePaymentVerification
                 )
             } else {
-                STPAPIClient.shared.verifySetupIntentWithMicrodeposits(
+                apiClient.verifySetupIntentWithMicrodeposits(
                     clientSecret: clientSecret as String,
                     firstAmount: amounts[0] as! Int,
                     secondAmount: amounts[1] as! Int,
@@ -966,13 +971,13 @@ class StripeSdk: RCTEventEmitter, STPApplePayContextDelegate, STPBankSelectionVi
             }
         } else if let descriptorCode = descriptorCode {
             if (isPaymentIntent) {
-                STPAPIClient.shared.verifyPaymentIntentWithMicrodeposits(
+                apiClient.verifyPaymentIntentWithMicrodeposits(
                     clientSecret: clientSecret as String,
                     descriptorCode: descriptorCode,
                     completion: onCompletePaymentVerification
                 )
             } else {
-                STPAPIClient.shared.verifySetupIntentWithMicrodeposits(
+                apiClient.verifySetupIntentWithMicrodeposits(
                     clientSecret: clientSecret as String,
                     descriptorCode: descriptorCode,
                     completion: onCompleteSetupVerification