Fixes a bug that defaults the relationship interaction style to Synchronous, when it's specifically set to null.

Author: simonbrowndotje

build.gradle

@@ -14,7 +14,7 @@ subprojects { proj ->
 
     description = 'Structurizr'
     group = 'com.structurizr'
-    version = '1.4.0'
+    version = '1.4.1'
 
     repositories {
         mavenCentral()

docs/changelog.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.4.1 (14th June 2020)
+
+Fixes a bug that defaults the relationship interaction style to Synchronous, when it's specifically set to null.
+
 ## 1.4.0 (5th June 2020)
 
 - Added a "Component" element shape.

structurizr-core/src/com/structurizr/model/Relationship.java

@@ -18,7 +18,7 @@ public final class Relationship extends ModelItem {
     private String destinationId;
     private String description;
     private String technology;
-    private InteractionStyle interactionStyle = InteractionStyle.Synchronous;
+    private InteractionStyle interactionStyle;
     private String url;
 
     private String linkedRelationshipId;
@@ -37,7 +37,7 @@ public final class Relationship extends ModelItem {
 
         if (interactionStyle == InteractionStyle.Synchronous) {
             addTags(Tags.SYNCHRONOUS);
-        } else {
+        } else if (interactionStyle == InteractionStyle.Asynchronous) {
             addTags(Tags.ASYNCHRONOUS);
         }
     }

structurizr-core/test/unit/com/structurizr/model/RelationshipTests.java

@@ -105,4 +105,13 @@ public void test_setUrl_DoesNothing_WhenAnEmptyUrlIsSpecified() {
         assertNull(relationship.getUrl());
     }
 
+    @Test
+    public void test_interactionStyle_CanBeSetToNull() {
+        Relationship relationship = softwareSystem1.uses(softwareSystem2, "Uses 1", "Technology", null);
+
+        assertNull(relationship.getInteractionStyle());
+        assertFalse(relationship.getTagsAsSet().contains(Tags.ASYNCHRONOUS));
+        assertFalse(relationship.getTagsAsSet().contains(Tags.SYNCHRONOUS));
+    }
+
 }