Skip to content

Nextcloud Talk 24.0.3 issues a warning of a missing feature_changed_users #1283

Description

@kaynemo

Hi all!
Nextcloud Talk 24.0.3 app issues a yellow warning that a changed_users feature connecting to 2.1.1 signaling server.

2.1.1 signaling server
X-Spreed-Signaling-Features: audio-video-permissions, chat-relay, dialout, federation, hello-v2, incall-all, join-features, mcu, offer-codecs, recipient-call, serverinfo, simulcast, switchto, transient-data, transient-sessiondata, update-sdp, welcome

24.0.3 Talk
sed -n '/getSignalingServerMissingFeatures/,/^\t}/p' apps/spreed.24.0.3.bak/lib/Signaling/Manager.php
$missingFeatures = $this->getSignalingServerMissingFeatures($features);
if (!empty($missingFeatures)) {
return [
'status' => Http::STATUS_OK,
'data' => [
'warning' => 'UPDATE_OPTIONAL',
'features' => $missingFeatures,
'version' => $data['version'],
],
];
}

		/**
		 * Store appconfig for some optional features that require different
		 * behaviour on PHP backend side
		 */
		if (in_array('changed-users', $features, true)) {
			$this->appConfig->setAppValueBool(Manager::HAS_FEATURE_CHANGED_USERS, true);
		}

		return [
			'status' => Http::STATUS_OK,
			'data' => [
				'version' => $data['version'],
			],
		];
	} catch (ConnectException) {
		return [
			'status' => Http::STATUS_INTERNAL_SERVER_ERROR,
			'data' => [
				'error' => 'CAN_NOT_CONNECT',
			],
		];
	} catch (\Exception $e) {
		return [
			'status' => Http::STATUS_INTERNAL_SERVER_ERROR,
			'data' => [
				'error' => (string)$e->getCode(),
			],
		];
	}

}
protected function getSignalingServerMissingFeatures(array $features): array {
	$optionFeatures = [
		'dialout',
		'join-features',
		'chat-relay',
		'changed-users',
	];

	return array_values(array_diff($optionFeatures, $features));
}

Just thought you should know. The missing feature is an "update optional" class, but I am sure a lot of people running a setup similar to mine will freak out.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions