Skip to content

Commit f829725

Browse files
authored
Prepare 14.0.0 (#204)
1 parent d0c62e5 commit f829725

File tree

7 files changed

+1188
-4200
lines changed

7 files changed

+1188
-4200
lines changed

.github/workflows/nodejs.yml

-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ on:
55
branches:
66
- main
77
pull_request:
8-
branches:
9-
- '**'
108

119
jobs:
1210
lint:

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## 14.0.0
4+
5+
- Removed: `stylelint` less than `16.0.0` from peer dependencies.
6+
- Removed: Node.js less than `18.12.0` support.
7+
38
## 13.0.0
49

510
- Removed: `stylelint` less than `15.10.0` from peer dependencies.

__tests__/engines.test.js __tests__/engines.test.mjs

+7-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
'use strict';
1+
import { describe, it } from 'node:test';
2+
import assert from 'node:assert/strict';
3+
import { execFileSync } from 'node:child_process';
4+
import { readFileSync } from 'node:fs';
25

3-
const { execFileSync } = require('child_process');
4-
const pkg = require('../package.json');
6+
const pkg = JSON.parse(readFileSync(new URL('../package.json', import.meta.url), 'utf8'));
57

68
describe('engines.node', () => {
79
it("is the same as stylelint's one", () => {
@@ -18,7 +20,7 @@ describe('engines.node', () => {
1820
// `^x.y.z` range can return multiple versions.
1921
const nodeVersions = Array.isArray(nodeVersion) ? [...new Set(nodeVersion)] : [nodeVersion];
2022

21-
expect(nodeVersions).toHaveLength(1);
22-
expect(nodeVersions).toContain(pkg.engines.node);
23+
assert.equal(nodeVersions.length, 1);
24+
assert.ok(nodeVersions.includes(pkg.engines.node));
2325
});
2426
});

__tests__/index.test.js

-81
This file was deleted.

__tests__/index.test.mjs

+86
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
1+
import { describe, it, beforeEach } from 'node:test';
2+
import assert from 'node:assert/strict';
3+
import { readFileSync } from 'node:fs';
4+
5+
import stylelint from 'stylelint';
6+
import config from '../index.js';
7+
8+
const validCss = readFileSync('./__tests__/valid.css', 'utf-8');
9+
const invalidCss = readFileSync('./__tests__/invalid.css', 'utf-8');
10+
11+
describe('flags no warnings with valid css', () => {
12+
let result;
13+
14+
beforeEach(async () => {
15+
result = await stylelint.lint({
16+
code: validCss,
17+
config,
18+
});
19+
});
20+
21+
it('has no errors', () => {
22+
assert.equal(result.errored, false);
23+
});
24+
25+
it('flags no warnings', () => {
26+
assert.equal(result.results[0].warnings.length, 0);
27+
});
28+
});
29+
30+
describe('flags warnings with invalid css', () => {
31+
let result;
32+
33+
beforeEach(async () => {
34+
result = await stylelint.lint({
35+
code: invalidCss,
36+
config,
37+
});
38+
});
39+
40+
it('includes an error', () => {
41+
assert.equal(result.errored, true);
42+
});
43+
44+
it('flags one warning', () => {
45+
assert.equal(result.results[0].warnings.length, 1);
46+
});
47+
48+
it('corrects warning text', () => {
49+
assert.equal(
50+
result.results[0].warnings[0].text,
51+
'Unexpected unknown type selector "madeup" (selector-type-no-unknown)',
52+
);
53+
});
54+
55+
it('corrects rule flagged', () => {
56+
assert.equal(result.results[0].warnings[0].rule, 'selector-type-no-unknown');
57+
});
58+
59+
it('corrects severity flagged', () => {
60+
assert.equal(result.results[0].warnings[0].severity, 'error');
61+
});
62+
63+
it('corrects line number', () => {
64+
assert.equal(result.results[0].warnings[0].line, 1);
65+
});
66+
67+
it('corrects column number', () => {
68+
assert.equal(result.results[0].warnings[0].column, 1);
69+
});
70+
});
71+
72+
describe('deprecated rules are excluded', () => {
73+
const ruleNames = Object.keys(config.rules);
74+
75+
it('is not empty', () => {
76+
assert.ok(ruleNames.length > 0);
77+
});
78+
79+
for (const ruleName of ruleNames) {
80+
it(`${ruleName}`, async () => {
81+
const rule = await stylelint.rules[ruleName];
82+
83+
assert.ok(!rule.meta.deprecated);
84+
});
85+
}
86+
});

0 commit comments

Comments
 (0)