Bump required VSCode version to 1.82.3 (#503)

Author: ybiquitous

.github/workflows/testing.yml

@@ -11,41 +11,29 @@ on:
 
 jobs:
   test:
-    name: Test for Stylelint ${{ matrix.stylelint }} on Node.js ${{ matrix.node-version }} and ${{ matrix.os }}
+    name: Test for Stylelint ${{ matrix.stylelint }} on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18]
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
         stylelint: [14, 15]
-        include:
-          - stylelint: 15
-            node-version: 14 # For some reason jest-runner-vscode doesn't work well with Node v18 and Windows.
-            os: windows-latest
-          - stylelint: 14
-            node-version: 14 # For some reason jest-runner-vscode doesn't work well with Node v18 and Windows.
-            os: windows-latest
     timeout-minutes: 30
     permissions:
       contents: read
     steps:
       - uses: actions/checkout@v4
 
-      - name: Use Node.js ${{ matrix.node-version }}
+      - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version-file: .nvmrc
           cache: npm
 
-      # TODO: [email protected] is broken on Windows. See https://github.com/npm/cli/issues/4341
-      - name: Workaround for npm installation failure on Node.js 14 and Windows
-        if: ${{ matrix.node-version == '14' && runner.os == 'Windows' }}
-        run: npm install --global [email protected]
-
       - name: Install latest npm
-        if: ${{ matrix.node-version == '18' }}
-        run: npm install --global npm@latest
+        # TODO: npm 10 requires Node.js 18.17 or later.
+        # run: npm install --global npm@latest
+        run: npm install --global npm@9
 
       - name: Install dependencies
         run: npm ci

.nvmrc

@@ -1 +1 @@
-14.17.6
+18.15.0

package-lock.json

@@ -18,8 +18,8 @@
   },
   "icon": "media/stylelint.png",
   "engines": {
-    "vscode": ">=1.56.0",
-    "node": ">=14.16.0"
+    "vscode": ">=1.82.3",
+    "node": ">=18.15.0"
   },
   "galleryBanner": {
     "color": "#000000",
@@ -225,7 +225,7 @@
     "@types/jest": "^27.0.3",
     "@types/path-is-inside": "^1.0.0",
     "@types/semver": "^7.3.9",
-    "@types/vscode": "1.56.0",
+    "@types/vscode": "1.82.0",
     "@typescript-eslint/eslint-plugin": "^5.5.0",
     "@typescript-eslint/parser": "^5.30.5",
     "@typescript/lib-dom": "npm:@types/web@^0.0.47",
@@ -280,7 +280,7 @@
   },
   "prettier": "@stylelint/prettier-config",
   "volta": {
-    "node": "14.17.6",
-    "npm": "8.1.3"
+    "node": "18.15.0",
+    "npm": "9.9.2"
   }
 }

package.json

@@ -83,7 +83,7 @@ Array [
       ],
     ],
     "isPreferred": undefined,
-    "kind": s {
+    "kind": _ {
       "value": "quickfix",
     },
     "title": "Disable indentation for this line",
@@ -112,7 +112,7 @@ Array [
       ],
     ],
     "isPreferred": undefined,
-    "kind": s {
+    "kind": _ {
       "value": "quickfix",
     },
     "title": "Disable indentation for the entire file",
@@ -128,7 +128,7 @@ Array [
       "title": "Open documentation for indentation",
     },
     "isPreferred": undefined,
-    "kind": s {
+    "kind": _ {
       "value": "quickfix",
     },
     "title": "Show documentation for indentation",

test/e2e/__tests__/__snapshots__/code-actions.ts.snap

@@ -1,10 +1,26 @@
 'use strict';
 
-const path = require('path');
+const path = require('node:path');
+const { readFileSync } = require('node:fs');
+
+const vscodeVersion = '1.82.3';
+
+const pkg = JSON.parse(readFileSync(path.join(__dirname, '../../package.json'), 'utf8'));
+const requiredVscodeVersion = pkg.engines.vscode.match(/\d+\.\d+\.\d+/)?.[0];
+
+if (!requiredVscodeVersion) {
+	throw new Error('Cannot find a VSCode version in package.json');
+}
+
+if (vscodeVersion !== requiredVscodeVersion) {
+	throw new Error(
+		`The required VSCode version in package.json is '${requiredVscodeVersion}', but actually '${vscodeVersion}'`,
+	);
+}
 
 /** @type {import('jest-runner-vscode').RunnerOptions} */
 const config = {
-	version: '1.56.2',
+	version: vscodeVersion,
 	launchArgs: ['--disable-extensions'],
 	openInFolder: true,
 	workspaceDir: path.join(__dirname, 'workspace/workspace.code-workspace'),

test/e2e/jest-runner-vscode.config.js

@@ -1,6 +1,6 @@
 {
 	"stylelint.customSyntax": "${workspaceFolder}/custom-syntax.js",
 	"editor.codeActionsOnSave": {
-		"source.fixAll.stylelint": true
+		"source.fixAll.stylelint": "explicit"
 	}
 }

test/e2e/workspace/custom-syntax/.vscode/settings.json

@@ -2,6 +2,6 @@
 	"stylelint.reportInvalidScopeDisables": true,
 	"stylelint.reportNeedlessDisables": true,
 	"editor.codeActionsOnSave": {
-		"source.fixAll.stylelint": false
+		"source.fixAll.stylelint": "never"
 	}
 }