Skip to content

Commit dd353d0

Browse files
authored
Update KB chart (#13)
* mount application.yaml to root folder * updated chart version * unique labels for api and frontend * using labels in different locations, too
1 parent 9c66308 commit dd353d0

File tree

7 files changed

+38
-18
lines changed

7 files changed

+38
-18
lines changed

charts/knowledge-base/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ apiVersion: v2
22
name: knowledge-base
33
description: Knowledge Base frontend and API/backend
44
type: application
5-
version: 0.1.0
5+
version: 0.1.1
66
appVersion: "0.0.1"

charts/knowledge-base/templates/_helpers.tpl

+26-6
Original file line numberDiff line numberDiff line change
@@ -31,21 +31,41 @@ Create chart name and version as used by the chart label.
3131
{{- end }}
3232

3333
{{/*
34-
Common labels
34+
Common labels API
3535
*/}}
36-
{{- define "knowledge-base.labels" -}}
36+
{{- define "knowledge-base-api.labels" -}}
3737
helm.sh/chart: {{ include "knowledge-base.chart" . }}
38-
{{ include "knowledge-base.selectorLabels" . }}
38+
{{ include "knowledge-base-api.selectorLabels" . }}
3939
{{- if .Chart.AppVersion }}
4040
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
4141
{{- end }}
4242
app.kubernetes.io/managed-by: {{ .Release.Service }}
4343
{{- end }}
4444

4545
{{/*
46-
Selector labels
46+
Common labels Frontend
4747
*/}}
48-
{{- define "knowledge-base.selectorLabels" -}}
49-
app.kubernetes.io/name: {{ include "knowledge-base.name" . }}
48+
{{- define "knowledge-base-frontend.labels" -}}
49+
helm.sh/chart: {{ include "knowledge-base.chart" . }}
50+
{{ include "knowledge-base-frontend.selectorLabels" . }}
51+
{{- if .Chart.AppVersion }}
52+
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
53+
{{- end }}
54+
app.kubernetes.io/managed-by: {{ .Release.Service }}
55+
{{- end }}
56+
57+
{{/*
58+
Selector labels API
59+
*/}}
60+
{{- define "knowledge-base-api.selectorLabels" -}}
61+
app.kubernetes.io/name: "{{ include "knowledge-base.name" . }}-api"
62+
app.kubernetes.io/instance: {{ .Release.Name }}
63+
{{- end }}
64+
65+
{{/*
66+
Selector labels Frontend
67+
*/}}
68+
{{- define "knowledge-base-frontend.selectorLabels" -}}
69+
app.kubernetes.io/name: "{{ include "knowledge-base.name" . }}-frontend"
5070
app.kubernetes.io/instance: {{ .Release.Name }}
5171
{{- end }}

charts/knowledge-base/templates/config.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ kind: ConfigMap
33
metadata:
44
name: {{ include "knowledge-base.fullname" . }}
55
labels:
6-
{{- include "knowledge-base.labels" . | nindent 4 }}
6+
{{- include "knowledge-base-api.labels" . | nindent 4 }}
77
data:
88
application.yml: |-
99
sophora:

charts/knowledge-base/templates/deployment_api.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ kind: Deployment
33
metadata:
44
name: "{{ include "knowledge-base.fullname" . }}-api"
55
labels:
6-
{{- include "knowledge-base.labels" . | nindent 4 }}
6+
{{- include "knowledge-base-api.labels" . | nindent 4 }}
77
spec:
88
replicas: 1
99
selector:
1010
matchLabels:
11-
{{- include "knowledge-base.selectorLabels" . | nindent 6 }}
11+
{{- include "knowledge-base-api.selectorLabels" . | nindent 6 }}
1212
template:
1313
metadata:
1414
annotations:
@@ -18,7 +18,7 @@ spec:
1818
{{- toYaml . | nindent 8 }}
1919
{{- end }}
2020
labels:
21-
{{- include "knowledge-base.selectorLabels" . | nindent 8 }}
21+
{{- include "knowledge-base-api.selectorLabels" . | nindent 8 }}
2222
spec:
2323
{{- with .Values.imagePullSecrets }}
2424
imagePullSecrets:
@@ -31,7 +31,7 @@ spec:
3131
imagePullPolicy: {{ .Values.api.image.pullPolicy }}
3232
volumeMounts:
3333
- name: config
34-
mountPath: "/workspace/application.yml"
34+
mountPath: "/application.yml"
3535
subPath: "application.yml"
3636
env:
3737
- name: sophora.client.server-connection.username

charts/knowledge-base/templates/deployment_frontend.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ kind: Deployment
33
metadata:
44
name: "{{ include "knowledge-base.fullname" . }}-frontend"
55
labels:
6-
{{- include "knowledge-base.labels" . | nindent 4 }}
6+
{{- include "knowledge-base-frontend.labels" . | nindent 4 }}
77
spec:
88
replicas: 1
99
selector:
1010
matchLabels:
11-
{{- include "knowledge-base.selectorLabels" . | nindent 6 }}
11+
{{- include "knowledge-base-frontend.selectorLabels" . | nindent 6 }}
1212
template:
1313
metadata:
1414
annotations:
@@ -17,7 +17,7 @@ spec:
1717
{{- toYaml . | nindent 8 }}
1818
{{- end }}
1919
labels:
20-
{{- include "knowledge-base.selectorLabels" . | nindent 8 }}
20+
{{- include "knowledge-base-frontend.selectorLabels" . | nindent 8 }}
2121
spec:
2222
{{- with .Values.imagePullSecrets }}
2323
imagePullSecrets:

charts/knowledge-base/templates/ingress.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ kind: Ingress
66
metadata:
77
name: {{ $fullName }}
88
labels:
9-
{{- include "knowledge-base.labels" . | nindent 4 }}
9+
{{- include "knowledge-base-frontend.labels" . | nindent 4 }}
1010
{{- with .Values.ingress.annotations }}
1111
annotations:
1212
{{- toYaml . | nindent 4 }}

charts/knowledge-base/templates/service.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ kind: Service
33
metadata:
44
name: {{ include "knowledge-base.fullname" . }}
55
labels:
6-
{{- include "knowledge-base.labels" . | nindent 4 }}
6+
{{- include "knowledge-base-frontend.labels" . | nindent 4 }}
77
spec:
88
type: {{ .Values.service.type }}
99
ports:
@@ -12,4 +12,4 @@ spec:
1212
protocol: TCP
1313
name: http
1414
selector:
15-
{{- include "knowledge-base.selectorLabels" . | nindent 4 }}
15+
{{- include "knowledge-base-frontend.selectorLabels" . | nindent 4 }}

0 commit comments

Comments
 (0)