Skip to content

Commit 1cd1c49

Browse files
committed
feedback-task: created ref_type oneof field
Created a oneof field, "ref_type," (should expand to `ref_type_case` for generated code) that captures both types of references. The old type, subtree_ordinal, has also been deprecated. This addresses feedback in the PR tagged below. PR: #726
1 parent c0906f7 commit 1cd1c49

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

proto/substrait/algebra.proto

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1636,9 +1636,11 @@ message AggregateFunction {
16361636
// This rel is used to create references,
16371637
// in case we refer to a RelRoot field names will be ignored
16381638
message ReferenceRel {
1639-
// points to a PlanRel in Plan.relations (ordinal reference)
1640-
int32 subtree_ordinal = 1;
1639+
oneof ref_type {
1640+
// points to a PlanRel in Plan.relations (ordinal reference)
1641+
int32 subtree_ordinal = 1 [deprecated = true];
16411642

1642-
// points to a subtree_anchor in PlanRel (for non-ordinal reference)
1643-
uint32 subtree_reference = 2;
1643+
// points to a subtree_anchor in PlanRel (for non-ordinal reference)
1644+
uint32 subtree_reference = 2;
1645+
}
16441646
}

0 commit comments

Comments
 (0)