small nits

Author: mattstam

contracts/.gas-snapshot

@@ -1,41 +1,41 @@
-ProverBoostAddTests:test_AddBoost_WhenCurrentProverFunction() (gas: 1018855)
-ProverBoostAddTests:test_AddBoost_WhenDifferentPerBoostPeriods() (gas: 1345568)
-ProverBoostAddTests:test_AddBoost_WhenFirstBoostAutoCreatesVault() (gas: 1057796)
-ProverBoostAddTests:test_AddBoost_WhenOpenParticipation() (gas: 1026869)
-ProverBoostAddTests:test_AddBoost_WhenSecondBoostUsesExistingVault() (gas: 1189562)
+ProverBoostAddTests:test_AddBoost_WhenCurrentProverFunction() (gas: 1018864)
+ProverBoostAddTests:test_AddBoost_WhenDifferentPerBoostPeriods() (gas: 1345577)
+ProverBoostAddTests:test_AddBoost_WhenFirstBoostAutoCreatesVault() (gas: 1057805)
+ProverBoostAddTests:test_AddBoost_WhenOpenParticipation() (gas: 1026878)
+ProverBoostAddTests:test_AddBoost_WhenSecondBoostUsesExistingVault() (gas: 1189571)
 ProverBoostAddTests:test_BoostPeriodToSeconds_AllValidOptions() (gas: 15600)
 ProverBoostAddTests:test_EnumOrderingAndValues() (gas: 4001)
-ProverBoostAddTests:test_PermitAndAddBoost_WhenValid() (gas: 975649)
-ProverBoostAddTests:test_RevertAddBoost_WhenInsufficientAllowance() (gas: 558309)
-ProverBoostAddTests:test_RevertAddBoost_WhenInsufficientBalance() (gas: 448925)
+ProverBoostAddTests:test_PermitAndAddBoost_WhenValid() (gas: 975658)
+ProverBoostAddTests:test_RevertAddBoost_WhenInsufficientAllowance() (gas: 558318)
+ProverBoostAddTests:test_RevertAddBoost_WhenInsufficientBalance() (gas: 448934)
 ProverBoostAddTests:test_RevertAddBoost_WhenUnspecifiedPeriod() (gas: 209120)
-ProverBoostAddTests:test_RevertAddBoost_WhenVaultBoundToDifferentProver() (gas: 1059842)
+ProverBoostAddTests:test_RevertAddBoost_WhenVaultBoundToDifferentProver() (gas: 1059851)
 ProverBoostAddTests:test_RevertAddBoost_WhenZeroAddress() (gas: 207499)
 ProverBoostAddTests:test_RevertAddBoost_WhenZeroAmount() (gas: 18680)
 ProverBoostAddTests:test_RevertBoostPeriodToSeconds_WhenUnspecified() (gas: 13826)
 ProverBoostCreateTests:test_BoostPeriodToSeconds_AllValidOptions() (gas: 15578)
 ProverBoostCreateTests:test_CurrentProver_WhenNoVault() (gas: 17505)
-ProverBoostCreateTests:test_CurrentProver_WhenVaultExists() (gas: 1016418)
+ProverBoostCreateTests:test_CurrentProver_WhenVaultExists() (gas: 1016427)
 ProverBoostCreateTests:test_EnumOrderingAndValues() (gas: 4000)
 ProverBoostCreateTests:test_MultipleAddresses_UnspecifiedDefault() (gas: 29221)
 ProverBoostCreateTests:test_RevertBoostPeriodToSeconds_WhenUnspecified() (gas: 13760)
 ProverBoostCreateTests:test_StakerToBoostVault_WhenNeverAddedBoost() (gas: 17308)
-ProverBoostCreateTests:test_StakerToBoostVault_WhenValidBoostExists() (gas: 1014710)
-ProverBoostEdgeTests:test_Misc_BoostIdManagement_WhenAddRemoveAddPattern() (gas: 1929960)
-ProverBoostEdgeTests:test_Misc_BoostIdManagement_WhenMaxGapScenario() (gas: 2699492)
-ProverBoostEdgeTests:test_Misc_BoostIdManagement_WhenRemoveAlreadyRemovedId() (gas: 1414850)
-ProverBoostEdgeTests:test_Misc_BoostIdManagement_WhenRemoveNonExistentId() (gas: 1031039)
-ProverBoostEdgeTests:test_Misc_PerBoostLockupPeriods_WhenDifferentPeriods() (gas: 1886608)
-ProverBoostRemoveTests:test_FinishRemoveBoost_WhenSomeoneElseFinishes() (gas: 1205560)
-ProverBoostRemoveTests:test_RemoveBoost_WhenDifferentPerBoostLockupPeriods() (gas: 2098772)
-ProverBoostRemoveTests:test_RemoveBoost_WhenMultipleBoosts() (gas: 1776105)
-ProverBoostRemoveTests:test_RemoveBoost_WhenOpenParticipation() (gas: 1211472)
-ProverBoostRemoveTests:test_RemoveBoost_WhenSameStakerDifferentPeriods() (gas: 1519054)
-ProverBoostRemoveTests:test_RemoveBoost_WhenValid() (gas: 1243525)
+ProverBoostCreateTests:test_StakerToBoostVault_WhenValidBoostExists() (gas: 1014719)
+ProverBoostEdgeTests:test_Misc_BoostIdManagement_WhenAddRemoveAddPattern() (gas: 1929967)
+ProverBoostEdgeTests:test_Misc_BoostIdManagement_WhenMaxGapScenario() (gas: 2699499)
+ProverBoostEdgeTests:test_Misc_BoostIdManagement_WhenRemoveAlreadyRemovedId() (gas: 1414857)
+ProverBoostEdgeTests:test_Misc_BoostIdManagement_WhenRemoveNonExistentId() (gas: 1031048)
+ProverBoostEdgeTests:test_Misc_PerBoostLockupPeriods_WhenDifferentPeriods() (gas: 1886615)
+ProverBoostRemoveTests:test_FinishRemoveBoost_WhenSomeoneElseFinishes() (gas: 1205567)
+ProverBoostRemoveTests:test_RemoveBoost_WhenDifferentPerBoostLockupPeriods() (gas: 2098786)
+ProverBoostRemoveTests:test_RemoveBoost_WhenMultipleBoosts() (gas: 1776112)
+ProverBoostRemoveTests:test_RemoveBoost_WhenOpenParticipation() (gas: 1211480)
+ProverBoostRemoveTests:test_RemoveBoost_WhenSameStakerDifferentPeriods() (gas: 1519061)
+ProverBoostRemoveTests:test_RemoveBoost_WhenValid() (gas: 1243532)
 ProverBoostRemoveTests:test_RevertFinishRemoveBoost_WhenBoostVaultDoesNotExist() (gas: 17623)
-ProverBoostRemoveTests:test_RevertFinishRemoveBoost_WhenNothingToFinish() (gas: 1020720)
-ProverBoostRemoveTests:test_RevertRequestRemoveBoost_WhenBoostNotFound() (gas: 1132771)
-ProverBoostRemoveTests:test_RevertRequestRemoveBoost_WhenBoostStillLocked() (gas: 1128928)
+ProverBoostRemoveTests:test_RevertFinishRemoveBoost_WhenNothingToFinish() (gas: 1020729)
+ProverBoostRemoveTests:test_RevertRequestRemoveBoost_WhenBoostNotFound() (gas: 1132778)
+ProverBoostRemoveTests:test_RevertRequestRemoveBoost_WhenBoostStillLocked() (gas: 1128935)
 ProverBoostRemoveTests:test_RevertRequestRemoveBoost_WhenBoostVaultDoesNotExist() (gas: 17707)
 SuccinctGovernorTest:test_Cancel_WhenValid() (gas: 454202)
 SuccinctGovernorTest:test_Execute_WhenSlashNoIndexShift() (gas: 1221270)

contracts/src/ProverBoost.sol

@@ -19,6 +19,8 @@ import {UUPSUpgradeable} from
 /// @title ProverBoost
 /// @author Succinct Labs
 /// @notice Manages boosted staking for any staker boosting any prover.
+/// @dev This wraps the SuccinctStaking staking mechanism with additional locked staking
+///      capabilities.
 contract ProverBoost is Initializable, OwnableUpgradeable, UUPSUpgradeable, IProverBoost {
     using SafeERC20 for IERC20;
 
@@ -249,7 +251,7 @@ contract ProverBoost is Initializable, OwnableUpgradeable, UUPSUpgradeable, IPro
         // Create the boost vault.
         bytes32 salt = keccak256(abi.encode(address(this), block.chainid, _staker));
         bytes memory bytecode = abi.encodePacked(
-            type(ProverBoostVault).creationCode, abi.encode(prove, _staker, address(this))
+            type(ProverBoostVault).creationCode, abi.encode(address(this), prove, _staker)
         );
         vault = Create2.deploy(0, salt, bytecode);
 

contracts/src/ProverBoostVault.sol

@@ -28,14 +28,14 @@ contract ProverBoostVault is IProverBoostVault {
         _;
     }
 
-    /// @dev Initializes this vault with the PROVE token, staker address, and boost manager.
-    /// @param _prove The PROVE token address.
-    /// @param _staker The staker address.
+    /// @dev Initializes this vault with the ProverBoost contract, $PROVE token, and staker address.
     /// @param _proverBoost The ProverBoost contract address.
-    constructor(address _prove, address _staker, address _proverBoost) {
+    /// @param _prove The $PROVE token address.
+    /// @param _staker The staker address.
+    constructor(address _proverBoost, address _prove, address _staker) {
+        proverBoost = _proverBoost;
         prove = _prove;
         staker = _staker;
-        proverBoost = _proverBoost;
     }
 
     /// @inheritdoc IProverBoostVault

contracts/test/ProverBoost.add.t.sol

@@ -26,7 +26,7 @@ contract ProverBoostAddTests is ProverBoostTest {
         // Calculate expected vault address using CREATE2
         bytes32 salt = keccak256(abi.encode(PROVER_BOOST, block.chainid, ALICE));
         bytes memory bytecode = abi.encodePacked(
-            type(ProverBoostVault).creationCode, abi.encode(PROVE, ALICE, PROVER_BOOST)
+            type(ProverBoostVault).creationCode, abi.encode(PROVER_BOOST, PROVE, ALICE)
         );
         address expectedVault = vm.computeCreate2Address(salt, keccak256(bytecode), PROVER_BOOST);