fix(test): simplify withdrawal test after respectedGameType fix

- Remove WaitForGameOfType workaround (no longer needed)
- Use WaitForGameCount(1) since respectedGameType is now correctly
  set to 42 in the submodule

The root cause (respectedGameType mismatch) is fixed in the optimism
submodule: succinctlabs/optimism#330

Author: fakedev9999

tests/e2e/faultproof/withdrawal/withdrawal_finalized_test.go

@@ -36,8 +36,7 @@ func TestFaultProofProposer_WithdrawalFinalized(gt *testing.T) {
 	l2User.VerifyBalanceExact(depositAmount)
 
 	// Log respected game type for debugging
-	respectedGameType := bridge.RespectedGameType()
-	logger.Info("Using respected game type", "gameType", respectedGameType)
+	logger.Info("Using respected game type", "gameType", bridge.RespectedGameType())
 
 	// Phase 1: Initiate withdrawal on L2
 	logger.Info("Phase 1: Initiating withdrawal on L2")
@@ -48,14 +47,13 @@ func TestFaultProofProposer_WithdrawalFinalized(gt *testing.T) {
 	expectedL2UserBalance := depositAmount.Sub(withdrawAmount).Sub(withdrawal.InitiateGasCost())
 	l2User.VerifyBalanceExact(expectedL2UserBalance)
 
-	// Wait for a game of the required type to be created before proving.
-	// The system may have games of other types (e.g., permissioned type 0),
-	// but the FP proposer creates games of the respected type.
+	// Wait for at least one game to be created before proving.
+	// The FP proposer needs time to batch L2 blocks and create games.
 	dgf := sys.DgfClient(t)
 	ctx, cancel := context.WithTimeout(t.Ctx(), utils.ShortTimeout())
 	defer cancel()
-	logger.Info("Waiting for game of required type")
-	utils.WaitForGameOfType(ctx, t, dgf, respectedGameType)
+	logger.Info("Waiting for dispute game creation")
+	utils.WaitForGameCount(ctx, t, dgf, 1)
 
 	// Phase 2: Prove withdrawal on L1
 	logger.Info("Phase 2: Proving withdrawal on L1")

tests/utils/adapters.go

@@ -185,37 +185,6 @@ func WaitForGameCount(ctx context.Context, t devtest.T, dgf *DgfClient, min uint
 	}
 }
 
-// WaitForGameOfType waits until a dispute game of the specified type exists.
-// This is needed because the system may have games of other types (e.g., permissioned type 0)
-// while the FP proposer creates games of type 1.
-func WaitForGameOfType(ctx context.Context, t devtest.T, dgf *DgfClient, gameType uint32) {
-	for {
-		gameCount, err := dgf.GameCount(ctx)
-		require.NoError(t, err, "failed to get game count from factory")
-
-		// Check all games (newest first) for matching type
-		for i := int64(gameCount) - 1; i >= 0; i-- {
-			game, err := dgf.GameAtIndex(ctx, uint64(i))
-			if err != nil {
-				continue
-			}
-			if game.GameType == gameType {
-				t.Logger().Info("Found game of required type", "index", i, "gameType", gameType)
-				return
-			}
-		}
-
-		t.Logger().Info("Waiting for game of required type...", "gameType", gameType, "totalGames", gameCount)
-
-		select {
-		case <-ctx.Done():
-			t.Errorf("timeout waiting for game of type %d", gameType)
-			t.FailNow()
-		case <-time.After(time.Second):
-		}
-	}
-}
-
 // -------------------------------------------------------------
 // Fault Dispute Game Client
 // -------------------------------------------------------------