webpack typescript type stuff

Author: suchipi

package-lock.json

@@ -13,7 +13,6 @@
     "@test-it/cli": "^0.8.0",
     "@test-it/core": "^0.8.0",
     "@types/lodash.debounce": "^4.0.9",
-    "@types/webpack": "^5.28.5",
     "aseprite-loader": "^0.1.3",
     "babel-loader": "^9.1.3",
     "bmfont-loader": "^0.2.0",

packages/scripts/package.json

@@ -23,25 +23,21 @@ export default async function build(options: { lib?: string; title?: string }) {
         title: options.title,
       });
 
-  // @ts-ignore
   const compiler = webpack(webpackConfig);
   return new Promise<void>((resolve, reject) => {
-    compiler.run((err: any, stats: any) => {
-      let messages;
+    compiler.run((err, stats) => {
       if (err != null) {
-        messages = {
-          errors: [err],
-          warnings: [],
-        };
-      } else {
-        messages = stats.toJson({
-          all: false,
-          warnings: true,
-          errors: true,
-        });
+        console.error(chalk.red(err));
+        return reject(err);
       }
 
-      if (messages.errors.length > 0) {
+      const messages = stats!.toJson({
+        all: false,
+        warnings: true,
+        errors: true,
+      });
+
+      if (messages.errors && messages.errors.length > 0) {
         for (const error of messages.errors) {
           console.error(chalk.red(error));
         }
@@ -52,6 +48,7 @@ export default async function build(options: { lib?: string; title?: string }) {
         process.env.CI &&
         (typeof process.env.CI !== "string" ||
           process.env.CI.toLowerCase() !== "false") &&
+        messages.warnings &&
         messages.warnings.length > 0
       ) {
         console.log(

packages/scripts/src/commands/build.ts

@@ -38,7 +38,7 @@ const makeWebpackConfig = ({
   outDir: string;
   library?: string;
   title?: string;
-}) => {
+}): webpack.Configuration => {
   const htmlWebpackPluginOptions: { [key: string]: any } = {
     title: title || "hex-engine game",
   };

packages/scripts/src/makeWebpackConfig.ts

@@ -66,19 +66,6 @@ export function load(filename: string): string {
     case ".tsx": {
       let config;
       if (filename.match(/node_modules/)) {
-        // We need to always compile ESM to CJS, because @hex-engine
-        // packages are published with ESM, but test-it can't run
-        // ESM unless the loader compiles it to CJS. Its default loader
-        // compiles ESM to CJS, but not for node_modules (for speed).
-        //
-        // The reason @hex-engine packages are published with ESM
-        // is because it allows webpack to treeshake unused named
-        // exports, which reduces the size of published games
-        // drastically, because it removes unused component functions.
-        //
-        // We could relax this to only compile node_modules/@hex-engine,
-        // but I want third-party hex-engine component libraries to be
-        // able to benefit from tree-shaking, too.
         config = {
           compact: true,
           plugins: ["@babel/plugin-transform-modules-commonjs"],

packages/scripts/src/test-it-loader.ts

@@ -3,7 +3,7 @@
     "./node_modules/aseprite-loader/index.d.ts",
     "./node_modules/xml-source-loader/index.d.ts",
     "./node_modules/bmfont-loader/index.d.ts",
-    "./packages/scripts/node_modules/@test-it/core/globals.d.ts",
+    "./node_modules/@test-it/core/globals.d.ts",
     "./ts-webpack.ts"
   ],
   "include": ["./packages/**/*.ts", "./packages/**/*.tsx"],
@@ -17,6 +17,7 @@
     "lib": ["es2019", "dom"],
     "target": "es2015",
     "module": "ES2015",
+    "skipLibCheck": true,
     "outDir": "./dist",
 
     "strict": true,