Invalid SPDX license expression in activity.info

[sidt4]

https://github.com/sugarlabs/memorize-activity/blob/master/activity/activity.info contains the following license.

license = GPLv2+;GPLv3+

which is not valid SPDX license expression. Hence it's reported as non-foss app in GNOME Software.

Refer https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2540

[quozl]

Indeed. The directory speak contains GPLv3+ licensed code, yet the main activity is GPLv2+ licensed code. Relicensing the GPLv2+ code as GPLv3+ would fix it.

[Iruag26]

Hi! I'd like to work on this issue. I'll update the license expression to a valid SPDX format. Let me know if it's okay to proceed.

[quozl]

Are you the author of the licensed code?

[quozl]

git grep -i copyright gives the copyright owners as;

activity.py:# Copyright (C) 2006, 2007, 2008 One Laptop Per Child
audio.py:# Copyright (C) 2006, 2007, 2008 One Laptop per Child
card.py:# Copyright (C) 2007, 2008 One Laptop per Child
cardlist.py:# Copyright (C) 2006, 2007, 2008 One Laptop per Child
cardtable.py:# Copyright (C) 2006, 2007, 2008 One Laptop per Child
createcardpanel.py:# Copyright (C) 2006, 2007, 2008 One Laptop per Child
createtoolbar.py:# Copyright (C) 2006, 2007, 2008 One Laptop per Child
game.py:# Copyright (C) 2006, 2007, 2008 One Laptop per Child
memorizetoolbar.py:# Copyright (C) 2006, 2007, 2008 One Laptop per Child
playerscoreboard.py:# Copyright (C) 2006, 2007, 2008 One Laptop per Child
model.py:# Copyright (C) 2006, 2007, 2008 One Laptop per Child
scoreboard.py:# Copyright (C) 2006, 2007, 2008 One Laptop per Child
speak/speech.py:# Copyright (C) 2011 One Laptop Per Child

createcardpanel.py:# Copyright (C) 2009 Simon Schampijer
activity.py:# Copyright (C) 2009 Simon Schampijer, Aleksey Lim

audio.py:# Copyright (C) 2013, Ignacio Rodriguez
card.py:# Copyright (C) 2013, Ignacio Rodriguez

collabwrapper.py:# Copyright (C) 2015 Walter Bender

collabwrapper.py:# Copyright (C) 2015 Sam Parkinson

face.py:# Copyright (C) 2009, Aleksey Lim

fontcombobox.py:# Copyright (C) 2012 Gonzalo Odiard <gonzalo@laptop.org>

port/roundbox.py:# Copyright 2014, Sugar Labs

setup.py:# Copyright (C) 2006, Red Hat, Inc.

speak/eye.py:# Copyright (C) 2008  Joshua Minor
speak/face.py:# Copyright (C) 2008  Joshua Minor
speak/mouth.py:# Copyright (C) 2008  Joshua Minor

speak/eye.py:# Copyright (C) 2007  Arjun Sarwal - arjun@laptop.org
speak/face.py:# Copyright (C) 2007  Arjun Sarwal - arjun@laptop.org
speak/mouth.py:# Copyright (C) 2007  Arjun Sarwal - arjun@laptop.org

I'm able to represent One Laptop per Child.

licensecheck shows GPLv3+ is collabwrapper.py. Relicensing that as GPLv2+ is the smallest change, which requires permission from Sam and Walter.