Skip to content

Commit 1857f05

Browse files
authored
Merge pull request #5850 from rashi-cse/fix_scrollbar_placement
Fixed Help Tutorial Scrollbar Placement
2 parents e5f6183 + 4583b68 commit 1857f05

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

css/activities.css

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1199,7 +1199,7 @@ table {
11991199
left: 0 !important;
12001200
border: 0 !important;
12011201
overflow-x: hidden;
1202-
overflow-y: auto;
1202+
overflow: visible;
12031203
width: calc(100% - 130px) !important;
12041204
max-width: 350px;
12051205
padding: 1rem 1rem 0 1rem;
@@ -1209,6 +1209,10 @@ table {
12091209
align-items: center;
12101210
}
12111211

1212+
#helpScrollWrapper {
1213+
overflow-y: auto;
1214+
}
1215+
12121216
#helpBodyDiv .heading,
12131217
#helpBodyDiv .description,
12141218
#helpBodyDiv .message {

js/widgets/help.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,10 @@ class HelpWidget {
8282
<div id="right-arrow" class="hover" tabindex="-1"></div>
8383
<div id="left-arrow" class="hover" tabindex="-1"></div>
8484
<div id="helpButtonsDiv" tabindex="-1"></div>
85-
<div id="helpBodyDiv" tabindex="-1"></div>
86-
`;
85+
<div id="helpScrollWrapper">
86+
<div id="helpBodyDiv" tabindex="-1"></div>
87+
</div>
88+
`;
8789

8890
this._helpDiv.insertAdjacentHTML("afterbegin", innerHTML);
8991
this.widgetWindow.getWidgetBody().append(this._helpDiv);
@@ -467,7 +469,7 @@ class HelpWidget {
467469
// this._helpDiv.style.backgroundColor = "#e8e8e8";
468470

469471
const helpDivHTML =
470-
'<div id="right-arrow" class="hover" tabindex="-1"></div><div id="left-arrow" class="hover" tabindex="-1"></div><div id="helpButtonsDiv" tabindex="-1"></div><div id="helpBodyDiv" tabindex="-1"></div>';
472+
'<div id="right-arrow" class="hover" tabindex="-1"></div><div id="left-arrow" class="hover" tabindex="-1"></div><div id="helpButtonsDiv" tabindex="-1"></div><div id="helpScrollWrapper"><div id="helpBodyDiv" tabindex="-1"></div></div>';
471473
this._helpDiv.insertAdjacentHTML("afterbegin", helpDivHTML);
472474

473475
this.widgetWindow.getWidgetBody().append(this._helpDiv);

0 commit comments

Comments
 (0)