Skip to content

Commit 247f475

Browse files
author
Vanshika
committed
Fix tour arrow overlap and update abc tests
- Move arrows to the edges of the dialog (right: 25px, left: 10px) to prevent overlap. - Increase clearance in the help dialog body to avoid collision with arrows. - Update abc.test.js to match the current precise output format of the abc engine.
1 parent fe8d4f6 commit 247f475

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

css/activities.css

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1051,12 +1051,12 @@ table {
10511051
}
10521052

10531053
#right-arrow {
1054-
left: 385px;
1054+
right: 25px;
10551055
background: url("../header-icons/right-arrow.png");
10561056
}
10571057

10581058
#left-arrow {
1059-
left: 5px;
1059+
left: 10px;
10601060
background: url("../header-icons/left-arrow.png");
10611061
}
10621062

@@ -1177,12 +1177,14 @@ table {
11771177

11781178
#helpBodyDiv {
11791179
position: relative;
1180-
left: 45px;
1180+
margin: 0 auto !important;
1181+
left: 0 !important;
11811182
border: 0 !important;
11821183
overflow-x: hidden;
11831184
overflow-y: auto;
1184-
width: 350px;
1185-
padding: 1rem 1rem 0 0;
1185+
width: calc(100% - 130px) !important;
1186+
max-width: 350px;
1187+
padding: 1rem 1rem 0 1rem;
11861188
display: flex;
11871189
flex-direction: column;
11881190
justify-content: center;
@@ -2107,7 +2109,7 @@ table {
21072109

21082110
#right-arrow {
21092111
left: auto !important; /* Unset the old fixed pixel value */
2110-
right: 10px !important; /* Stick to the right edge */
2112+
right: 25px !important; /* Stick to the right edge */
21112113
}
21122114

21132115
/* --- Desktop View (Screens wider than 900px) --- */
@@ -2138,7 +2140,8 @@ table {
21382140

21392141
/* Fix the inner text box width so it doesn't overflow */
21402142
#helpBodyDiv {
2141-
width: 100% !important;
2143+
width: calc(100% - 110px) !important;
2144+
margin: 0 auto !important;
21422145
left: 0 !important;
21432146
padding: 0 10px;
21442147
box-sizing: border-box;

js/__tests__/abc.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ describe("processABCNotes - Tuplet Handling", () => {
229229
];
230230

231231
processABCNotes(logo, "0");
232-
expect(logo.notationNotes["0"]).toBe("(1:1G^ 2G^ 2G^ 2 ");
232+
expect(logo.notationNotes["0"]).toBe("(1:1G^ 2G^ 2G^ 2 ");
233233
});
234234

235235
it("should handle array of notes (chords) inside tuplets", () => {
@@ -366,7 +366,7 @@ describe("processABCNotes - Tuplet Handling", () => {
366366
};
367367

368368
processABCNotes(logo, "0");
369-
expect(logo.notationNotes["0"]).toBe("(1:1G^ 2G^ 2G^ 2 ");
369+
expect(logo.notationNotes["0"]).toBe("(1:1G^ 2G^ 2G^ 2 ");
370370
});
371371
});
372372

0 commit comments

Comments
 (0)