Fixed overlapping notes in simple tuplet block; reused noteBeatValue without introducing new variables

Author: Ganasekhar-gif

js/blocks/RhythmBlockPaletteBlocks.js

@@ -941,8 +941,8 @@ function setupRhythmBlockPaletteBlocks(activity) {
                 arg1 = args[1];
             }
 
-            const totalDuration = (1 / arg1) * activity.turtles.ithTurtle(turtle).singer.beatFactor;
-            const noteBeatValue = totalDuration / arg0;
+            const noteBeatValue = (1 / arg1) * activity.turtles.ithTurtle(turtle).singer.beatFactor;
+        
             if (logo.inMatrix || logo.tuplet) {
                 logo.phraseMaker.addColBlock(blk, arg0);
                 if (logo.tuplet) {
@@ -975,10 +975,9 @@ function setupRhythmBlockPaletteBlocks(activity) {
 
                 tur.singer.inNoteBlock.push(blk);
 
-                const bpmFactor =
-                    TONEBPM / tur.singer.bpm.length > 0 ? last(tur.singer.bpm) : Singer.masterBPM;
+                const bpmFactor = TONEBPM / tur.singer.bpm.length > 0 ? last(tur.singer.bpm) : Singer.masterBPM;
 
-                const beatValue = noteBeatValue;
+                const beatValue = (noteBeatValue / arg0) * (TONEBPM / bpmFactor);
 
                 const __rhythmPlayNote = (thisBeat, blk, turtle, callback, timeout) => {
                     setTimeout(
@@ -996,9 +995,7 @@ function setupRhythmBlockPaletteBlocks(activity) {
                         };
                     } else {
                         __callback = null;
-                    }
-
-                    const delay = i * beatValue * 1000;  
+                    } 
 
                     __rhythmPlayNote(
                         noteBeatValue,