test: expand RhythmBlocks test suite coverage (#5607)

Author: moksha-hub

js/blocks/__tests__/RhythmBlocks.test.js

@@ -450,4 +450,138 @@ describe("RhythmBlocks", () => {
             expect(block.hidden).toBe(true);
         });
     });
+
+    describe("Edge Cases and Additional Coverage", () => {
+        test("MyNoteValueBlock handles undefined connections gracefully", () => {
+            activity.blocks.blockList[1] = { connections: undefined };
+            global.Singer.RhythmActions.getNoteValue.mockReturnValue(0);
+
+            const block = getBlock("mynotevalue");
+            const result = block.arg(logo, 0, 1);
+
+            expect(result).toBe(0);
+        });
+
+        test("SkipNotesBlock handles zero skip value", () => {
+            turtle.singer.skipFactor = 0;
+            const block = getBlock("skipnotes");
+            block.flow([0, true], logo, 0, 10);
+
+            expect(turtle.singer.skipFactor).toBe(0);
+        });
+
+        test("SkipNotesBlock handles negative skip value", () => {
+            turtle.singer.skipFactor = 0;
+            const block = getBlock("skipnotes");
+            block.flow([-5, true], logo, 0, 10);
+
+            expect(turtle.singer.skipFactor).toBe(-5);
+        });
+
+        test("MultiplyBeatFactorBlock handles fractional factor", () => {
+            const block = getBlock("multiplybeatfactor");
+            block.flow([0.5, true], logo, 0, 10);
+
+            expect(global.Singer.RhythmActions.multiplyNoteValue).toHaveBeenCalledWith(0.5, 0, 10);
+        });
+
+        test("RhythmicDotBlock handles single dot", () => {
+            const block = getBlock("rhythmicdot");
+            block.flow([true], logo, 0, 10);
+
+            expect(global.Singer.RhythmActions.doRhythmicDot).toHaveBeenCalledWith(1, 0, 10);
+        });
+
+        test("RhythmicDot2Block handles multiple dots", () => {
+            const block = getBlock("rhythmicdot2");
+            block.flow([3, true], logo, 0, 10);
+
+            expect(global.Singer.RhythmActions.doRhythmicDot).toHaveBeenCalledWith(3, 0, 10);
+        });
+
+        test("NewNoteBlock registers correctly", () => {
+            const block = getBlock("newnote");
+            expect(block).toBeDefined();
+            expect(block.formDefn.args).toBe(2);
+        });
+
+        test("NoteBlock macros are defined", () => {
+            const noteBlocks = ["note1", "note2", "note3", "note4", "note5", "note6", "note7", "note8"];
+            noteBlocks.forEach(blockName => {
+                const block = getBlock(blockName);
+                expect(block).toBeDefined();
+                expect(block.macro).toBeDefined();
+            });
+        });
+
+        test("OctaveSpaceBlock is defined", () => {
+            const block = getBlock("octavespace");
+            expect(block).toBeDefined();
+        });
+
+        test("DefineFrequencyBlock is defined", () => {
+            const block = getBlock("definefrequency");
+            expect(block).toBeDefined();
+        });
+
+        test("All rhythm blocks have proper palette assignment", () => {
+            const rhythmBlockNames = [
+                "mynotevalue", "skipfactor", "osctime", "swing", "newswing", 
+                "newswing2", "skipnotes", "multiplybeatfactor", "tie", 
+                "rhythmicdot", "rhythmicdot2", "rest2", "note", "newnote"
+            ];
+            
+            rhythmBlockNames.forEach(blockName => {
+                const block = activity.registeredBlocks[blockName];
+                if (block) {
+                    expect(block.palette).toBe("rhythm");
+                }
+            });
+        });
+
+        test("Flow blocks return correct tuple format", () => {
+            const flowBlocks = ["swing", "newswing2", "skipnotes", "multiplybeatfactor", "tie"];
+            
+            flowBlocks.forEach(blockName => {
+                const block = getBlock(blockName);
+                if (block && block.flow) {
+                    const result = block.flow([1, true], logo, 0, 10);
+                    if (result) {
+                        expect(Array.isArray(result)).toBe(true);
+                        expect(result.length).toBe(2);
+                    }
+                }
+            });
+        });
+    });
+
+    describe("Error Handling", () => {
+        test("handles logo with missing statusFields", () => {
+            logo.inStatusMatrix = true;
+            logo.statusFields = undefined;
+            activity.blocks.blockList[1] = { connections: [2] };
+            activity.blocks.blockList[2] = { name: "print" };
+
+            const block = getBlock("mynotevalue");
+            expect(() => block.arg(logo, 0, 1)).not.toThrow();
+        });
+
+        test("handles turtle with missing singer object", () => {
+            activity.turtles.ithTurtle = jest.fn(() => ({}));
+            activity.blocks.blockList[1] = { connections: [0] };
+
+            const block = getBlock("skipfactor");
+            expect(() => block.arg(logo, 0, 1)).not.toThrow();
+        });
+
+        test("handles null blockList entries", () => {
+            activity.blocks.blockList = { 0: null, 1: null };
+            global.Singer.RhythmActions.getNoteValue.mockReturnValue(0);
+
+            const block = getBlock("mynotevalue");
+            const result = block.arg(logo, 0, 1);
+
+            expect(result).toBe(0);
+        });
+    });
 });