Skip to content

Commit 9a56bb0

Browse files
committed
refactor: align with master naming convention (this._deps -> this.deps)
1 parent 14b275e commit 9a56bb0

File tree

3 files changed

+69
-78
lines changed

3 files changed

+69
-78
lines changed

js/LogoDependencies.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@
1313
* @file LogoDependencies.js
1414
* @description Explicit dependency container for the Logo execution engine.
1515
*
16-
* This class makes Logo's dependencies explicit rather than accessing them
17-
* through the global Activity facade, improving testability and code clarity.
16+
* This class manages Logo's explicit dependencies.
1817
*/
1918

2019
/**
@@ -151,7 +150,7 @@ class LogoDependencies {
151150
*/
152151
this.meSpeak = meSpeak;
153152

154-
// Audio and utility dependencies from Logo Subsystem refactor
153+
// Audio and utility dependencies
155154
this.instruments =
156155
instruments || (typeof window !== "undefined" ? window.instruments : null);
157156
this.instrumentsFilters =

js/__tests__/logo-dependencies.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ describe("Logo with LogoDependencies", () => {
116116

117117
test("Logo accepts LogoDependencies object", () => {
118118
const logo = new Logo(mockDeps);
119-
expect(logo._deps).toBe(mockDeps);
119+
expect(logo.deps).toBe(mockDeps);
120120
expect(logo.activity.blocks).toBe(mockDeps.blocks);
121121
});
122122

@@ -136,7 +136,7 @@ describe("Logo with LogoDependencies", () => {
136136

137137
const logo = new Logo(mockActivity);
138138
expect(logo.activity).toBe(mockActivity);
139-
expect(logo._deps.blocks).toBe(mockActivity.blocks);
139+
expect(logo.deps.blocks).toBe(mockActivity.blocks);
140140
});
141141

142142
test("Error handler is called correctly", () => {
@@ -155,8 +155,8 @@ describe("Logo with LogoDependencies", () => {
155155

156156
test("Audio dependencies are correctly injected", () => {
157157
const logo = new Logo(mockDeps);
158-
expect(logo._deps.instruments).toBe(mockDeps.instruments);
159-
expect(logo._deps.Singer).toBe(mockDeps.Singer);
158+
expect(logo.deps.instruments).toBe(mockDeps.instruments);
159+
expect(logo.deps.Singer).toBe(mockDeps.Singer);
160160
});
161161
});
162162

0 commit comments

Comments
 (0)