Merge pull request #6159 from sonalgaud12/cli-fix

Fix: ESLint workflow and add pre-commit hooks

Author: omsuneri

.github/workflows/linter.yml

@@ -1,15 +1,11 @@
-name: ESLint
-
+name: ESLint & Prettier
 on:
     pull_request:
         branches: [master]
-
 jobs:
     lint:
-        name: Lint updated JavaScript files with ESLint
-
+        name: Lint and format-check changed JS files
         runs-on: ubuntu-latest
-
         steps:
             - name: Checkout code
               uses: actions/checkout@v4
@@ -23,26 +19,29 @@ jobs:
                   node-version: 20.x
                   cache: "npm"
 
+            - name: Install dependencies
+              run: npm ci
+
             - name: Get changed JavaScript files
               id: get_files
               run: |
-                  CHANGED_FILES=$(git diff --diff-filter=ACMRT --name-only ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} -- '*.js')
-                  echo "files<<EOF" >> $GITHUB_ENV
-                  echo "$CHANGED_FILES" >> $GITHUB_ENV
-                  echo "EOF" >> $GITHUB_ENV
-
-            - name: Install dependencies
-              run: npm ci
+                  git diff --diff-filter=ACMRT --name-only ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} -- '*.js' '*.mjs' ':!node_modules/**' > changed-js-files.txt
+                  if [ -s changed-js-files.txt ]; then
+                    echo "has_files=true" >> "$GITHUB_OUTPUT"
+                  else
+                    echo "has_files=false" >> "$GITHUB_OUTPUT"
+                  fi
 
             - name: Run ESLint on changed files
-              if: env.files != ''
+              if: steps.get_files.outputs.has_files == 'true'
               run: |
                   echo "Linting the following files:"
-                  echo "$files"
-                  echo "$files" | xargs npx eslint
+                  cat changed-js-files.txt
+                  xargs -r npx eslint < changed-js-files.txt
+
             - name: Run Prettier check on changed files
-              if: env.files != ''
+              if: steps.get_files.outputs.has_files == 'true'
               run: |
                   echo "Checking formatting for the following files:"
-                  echo "$files"
-                  echo "$files" | xargs npx prettier --check
+                  cat changed-js-files.txt
+                  xargs -r npx prettier --check < changed-js-files.txt

.husky/pre-commit

@@ -0,0 +1,2 @@
+#!/usr/bin/env sh
+npx lint-staged