Skip to content

Commit bbeb6fe

Browse files
authored
Fix memory leak from window widget document event listeners (#4901) (#4913)
* Fix memory leak by removing document-level event listeners in WidgetWindow * Format widgetWindows.js with Prettier
1 parent 36e24c8 commit bbeb6fe

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

js/widgets/widgetWindows.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -530,6 +530,15 @@ class WidgetWindow {
530530
* @returns {void}
531531
*/
532532
destroy() {
533+
if (this._dragTopHandler) {
534+
document.removeEventListener("mouseup", this._dragTopHandler, true);
535+
}
536+
if (this._docMouseMoveHandler) {
537+
document.removeEventListener("mousemove", this._docMouseMoveHandler, true);
538+
}
539+
if (this._docMouseDownHandler) {
540+
document.removeEventListener("mousedown", this._docMouseDownHandler, true);
541+
}
533542
if (this._frame && this._frame.parentElement) {
534543
this._frame.parentElement.removeChild(this._frame);
535544
}

0 commit comments

Comments
 (0)