refactor: centralize ensureABCJS loader and fix tests

Author: parthdagia05

js/activity.js

@@ -49,8 +49,6 @@
    globalActivity, hideArrows, doAnalyzeProject
  */
 
-import { ensureABCJS } from "./utils/abcLoader.js";
-
 const LEADING = 0;
 const BLOCKSCALES = [1, 1.5, 2, 3, 4];
 const _THIS_IS_MUSIC_BLOCKS_ = true;
@@ -203,25 +201,6 @@ if (_THIS_IS_MUSIC_BLOCKS_) {
 //   instead of reaching through window.* globals.
 let globalActivity;
 
-/**
- * Ensures the ABCJS library is loaded.
- * If already loaded, resolves immediately.
- * Otherwise, dynamically appends the script and resolves on load.
- * @returns {Promise<void>}
- */
-function ensureABCJS() {
-    if (typeof window !== "undefined" && window.ABCJS) return Promise.resolve();
-    if (typeof window === "undefined") return Promise.resolve();
-
-    return new Promise((resolve, reject) => {
-        const script = document.createElement("script");
-        script.src = "lib/abc.min.js";
-        script.onload = resolve;
-        script.onerror = reject;
-        document.head.appendChild(script);
-    });
-}
-
 /**
  * Performs analysis on the project using the global activity.
  * @returns {object} - The analysis result.

js/blocks/GraphicsBlocks.js

@@ -97,8 +97,7 @@ function setupGraphicsBlocks(activity) {
          * @returns {number} - The heading value.
          */
         arg(logo, turtle, blk) {
-            const blockList = activity?.blocks?.blockList || [];
-            const connections = blockList[blk]?.connections;
+            const connections = activity.blocks.blockList[blk]?.connections;
             const parentId = connections?.[0];
             if (
                 logo.inStatusMatrix &&
@@ -183,8 +182,7 @@ function setupGraphicsBlocks(activity) {
          * @returns {number} - The Y-coordinate value.
          */
         arg(logo, turtle, blk) {
-            const blockList = activity?.blocks?.blockList || [];
-            const connections = blockList[blk]?.connections;
+            const connections = activity.blocks.blockList[blk]?.connections;
             const parentId = connections?.[0];
             if (
                 logo.inStatusMatrix &&
@@ -270,8 +268,7 @@ function setupGraphicsBlocks(activity) {
          * @returns {number} - The X-coordinate value.
          */
         arg(logo, turtle, blk) {
-            const blockList = activity?.blocks?.blockList || [];
-            const connections = blockList[blk]?.connections;
+            const connections = activity.blocks.blockList[blk]?.connections;
             const parentId = connections?.[0];
             if (
                 logo.inStatusMatrix &&

js/utils/abcLoader.js

@@ -1,22 +1,42 @@
-export async function ensureABCJS() {
-    if (typeof window !== "undefined" && window.ABCJS) return;
-    if (typeof window === "undefined") return;
+function ensureABCJS() {
+    if (typeof window !== "undefined" && window.ABCJS) {
+        return Promise.resolve();
+    }
+
+    if (typeof window === "undefined") {
+        return Promise.resolve();
+    }
 
     return new Promise((resolve, reject) => {
         const existing = document.querySelector('script[src="lib/abc.min.js"]');
+
         if (existing) {
-            if (existing.hasAttribute('data-loaded')) resolve();
-            else existing.addEventListener('load', resolve);
+            if (existing.hasAttribute("data-loaded")) {
+                resolve();
+            } else {
+                existing.addEventListener("load", resolve);
+            }
             return;
         }
 
         const script = document.createElement("script");
         script.src = "lib/abc.min.js";
+
         script.onload = () => {
-            script.setAttribute('data-loaded', 'true');
+            script.setAttribute("data-loaded", "true");
             resolve();
         };
+
         script.onerror = reject;
+
         document.head.appendChild(script);
     });
 }
+
+if (typeof window !== "undefined") {
+    window.ensureABCJS = ensureABCJS;
+}
+
+if (typeof module !== "undefined" && module.exports) {
+    module.exports = ensureABCJS;
+}

js/widgets/aiwidget.js

@@ -18,7 +18,6 @@
 */
 
 /* exported Abhijeet Singh */
-import { ensureABCJS } from "../utils/abcLoader.js";
 
 /**
  * Represents a AI Widget.
@@ -31,23 +30,6 @@ function AIWidget() {
     // Don't include natural when construcing the note name...
     const EXPORTACCIDENTALNAMES = [DOUBLEFLAT, FLAT, "", SHARP, DOUBLESHARP];
 
-    /**
-     * Ensures the ABCJS library is loaded.
-     * Dynamically appends the script if not already present.
-     * @returns {Promise<void>}
-     */
-    function ensureABCJS() {
-        if (typeof window !== "undefined" && window.ABCJS) return Promise.resolve();
-        if (typeof window === "undefined") return Promise.resolve();
-
-        return new Promise((resolve, reject) => {
-            const script = document.createElement("script");
-            script.src = "lib/abc.min.js";
-            script.onload = resolve;
-            script.onerror = reject;
-            document.head.appendChild(script);
-        });
-    }
     // ...but display it in the selector.
     const ACCIDENTALNAMES = [DOUBLEFLAT, FLAT, NATURAL, SHARP, DOUBLESHARP];
     const SOLFEGENAMES = ["do", "re", "mi", "fa", "sol", "la", "ti", "do"];
@@ -895,7 +877,7 @@ function AIWidget() {
      * @returns {void}
      */
     this._playABCSong = async function () {
-        await ensureABCJS();
+        await window.ensureABCJS();
         const abc = abcNotationSong;
         const stopAudioButton = document.querySelector(".stop-audio");