Skip to content

Commit d17b333

Browse files
committed
test: Fix state leakage in search widget tests
1 parent 75e7f78 commit d17b333

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

js/__tests__/search_widget_fix.test.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ describe("Search Widget Listener Fix", () => {
151151

152152
// Re-inject mocks that might be overwritten or needed
153153
activity.searchWidget = sandbox.document.getElementById("search");
154+
activity.searchWidget.style.visibility = "hidden";
154155
activity.palettes = new sandbox.Palettes();
155156
activity.doSearch = jest.fn();
156157

@@ -202,6 +203,9 @@ describe("Search Widget Listener Fix", () => {
202203

203204
listener({ target: searchElem });
204205

206+
// Restore mock to default behavior so it doesn't leak
207+
searchElem.contains.mockImplementation(target => target === searchElem);
208+
205209
// Verify removeEventListener was NOT called for this listener
206210
const removeCalls = activity.removeEventListener.mock.calls.filter(c => c[2] === listener);
207211
expect(removeCalls.length).toBe(0);

0 commit comments

Comments
 (0)