fix: route effects in serial chain to prevent audio signal duplication (#5631)

* fix: route effects in serial chain to prevent audio signal duplication

Signed-off-by: Ady0333 <adityashinde1525@gmail.com>

* prettier

---------

Signed-off-by: Ady0333 <adityashinde1525@gmail.com>
Co-authored-by: Walter Bender <walter@sorceo.com>

Author: Ady0333

js/utils/synthutils.js

@@ -1726,6 +1726,9 @@ function Synth() {
                     console.debug("Error triggering note:", e);
                 }
             } else {
+                const effectChain = [];
+                synth.disconnect();
+
                 if (paramsFilters !== null && paramsFilters !== undefined) {
                     numFilters = paramsFilters.length; // no. of filters
                     for (let k = 0; k < numFilters; k++) {
@@ -1736,7 +1739,7 @@ function Synth() {
                             paramsFilters[k].filterRolloff
                         );
                         temp_filters.push(filterVal);
-                        synth.chain(temp_filters[k], Tone.Destination);
+                        effectChain.push(temp_filters[k]);
                     }
                 }
 
@@ -1752,26 +1755,22 @@ function Synth() {
                             1 / paramsEffects.vibratoFrequency,
                             paramsEffects.vibratoIntensity
                         );
-                        synth.chain(vibrato, Tone.Destination);
+                        effectChain.push(vibrato);
                         effectsToDispose.push(vibrato);
                     }
 
                     if (paramsEffects.doDistortion) {
-                        distortion = new Tone.Distortion(
-                            paramsEffects.distortionAmount
-                        ).toDestination();
-                        synth.connect(distortion, Tone.Destination);
+                        distortion = new Tone.Distortion(paramsEffects.distortionAmount);
+                        effectChain.push(distortion);
                         effectsToDispose.push(distortion);
                     }
 
                     if (paramsEffects.doTremolo) {
                         tremolo = new Tone.Tremolo({
                             frequency: paramsEffects.tremoloFrequency,
                             depth: paramsEffects.tremoloDepth
-                        })
-                            .toDestination()
-                            .start();
-                        synth.chain(tremolo);
+                        }).start();
+                        effectChain.push(tremolo);
                         effectsToDispose.push(tremolo);
                     }
 
@@ -1780,8 +1779,8 @@ function Synth() {
                             frequency: paramsEffects.rate,
                             octaves: paramsEffects.octaves,
                             baseFrequency: paramsEffects.baseFrequency
-                        }).toDestination();
-                        synth.chain(phaser, Tone.Destination);
+                        });
+                        effectChain.push(phaser);
                         effectsToDispose.push(phaser);
                     }
 
@@ -1790,8 +1789,8 @@ function Synth() {
                             frequency: paramsEffects.chorusRate,
                             delayTime: paramsEffects.delayTime,
                             depth: paramsEffects.chorusDepth
-                        }).toDestination();
-                        synth.chain(chorus, Tone.Destination);
+                        });
+                        effectChain.push(chorus);
                         effectsToDispose.push(chorus);
                     }
 
@@ -1847,6 +1846,12 @@ function Synth() {
                     }
                 }
 
+                if (effectChain.length > 0) {
+                    synth.chain(...effectChain, Tone.Destination);
+                } else {
+                    synth.toDestination();
+                }
+
                 if (!paramsEffects.doNeighbor) {
                     if (setNote !== undefined && setNote) {
                         if (synth.oscillator !== undefined) {