chore: address review feedback on pitch helpers

Author: vanshika2720

js/__tests__/logo.test.js

@@ -57,7 +57,7 @@ global.doStopVideoCam = jest.fn();
 global.CAMERAVALUE = "camera:";
 global.VIDEOVALUE = "video:";
 global.doUseCamera = jest.fn();
-global.delayExecution = jest.fn(ms => Promise.resolve());
+global.delayExecution = jest.fn((ms, callback) => callback());
 global.getStatsFromNotation = jest.fn();
 global.Tone = {
     UserMedia: jest.fn().mockImplementation(() => ({
@@ -230,12 +230,13 @@ describe("Logo Class", () => {
             },
             stage: {
                 removeEventListener: jest.fn(),
-                addEventListener: jest.fn(),
-                update: jest.fn()
+                addEventListener: jest.fn()
             },
             onStopTurtle: jest.fn(),
             onRunTurtle: jest.fn(),
-
+            meSpeak: {
+                speak: jest.fn()
+            },
             errorMsg: jest.fn(),
             saveLocally: jest.fn(),
             hideMsgs: jest.fn(),
@@ -370,6 +371,23 @@ describe("Logo Class", () => {
         });
     });
 
+    describe("processSpeak", () => {
+        test("filters text to only valid characters", () => {
+            // The code uses this._meSpeak
+            logo._meSpeak = { speak: jest.fn() };
+            logo.processSpeak("Hello, World! 123");
+
+            expect(logo._meSpeak.speak).toHaveBeenCalledWith("Hello, World ");
+        });
+
+        test("handles empty string", () => {
+            logo._meSpeak = { speak: jest.fn() };
+            logo.processSpeak("");
+
+            expect(logo._meSpeak.speak).toHaveBeenCalledWith("");
+        });
+    });
+
     describe("setTurtleListener", () => {
         test("adds event listener to stage", () => {
             const listener = jest.fn();
@@ -709,8 +727,7 @@ describe("Logo comprehensive method coverage", () => {
             stage: {
                 addEventListener: jest.fn(),
                 removeEventListener: jest.fn(),
-                dispatchEvent: jest.fn(),
-                update: jest.fn()
+                dispatchEvent: jest.fn()
             },
             errorMsg: jest.fn(),
             textMsg: jest.fn(),
@@ -918,7 +935,6 @@ describe("Logo comprehensive method coverage", () => {
         const originalTone = global.Tone;
         const open = jest.fn();
         global.Tone = { UserMedia: jest.fn(() => ({ open })) };
-        if (logo.deps) logo.deps.Tone = global.Tone;
 
         logo.initMediaDevices();
         expect(open).toHaveBeenCalled();
@@ -932,13 +948,11 @@ describe("Logo comprehensive method coverage", () => {
                 })
             }))
         };
-        if (logo.deps) logo.deps.Tone = global.Tone;
         logo.initMediaDevices();
         expect(mockActivity.errorMsg).toHaveBeenCalledWith("The microphone is not available.");
         expect(logo.mic).toBeNull();
 
         global.Tone = originalTone;
-        if (logo.deps) logo.deps.Tone = global.Tone;
     });
 
     test("processShow handles image/url/loadFile/default branches", () => {
@@ -962,7 +976,6 @@ describe("Logo comprehensive method coverage", () => {
             return 2;
         });
         global.delayExecution = jest.fn(() => Promise.resolve());
-        if (logo.deps && logo.deps.utils) logo.deps.utils.delayExecution = global.delayExecution;
 
         turtle0.singer.embeddedGraphics = {};
         await logo.dispatchTurtleSignals(0, 0.5, 3, 0);
@@ -1068,7 +1081,6 @@ describe("Logo comprehensive method coverage", () => {
     test("doStopTurtles covers companion/camera/recorder/showBlocks branches", () => {
         const clearIntervalSpy = jest.spyOn(global, "clearInterval").mockImplementation(() => {});
         global.instruments = { 0: { flute: {} }, 1: { piano: {} } };
-        if (logo.deps && logo.deps.instruments) logo.deps.instruments = global.instruments;
         turtle0.singer.killAllVoices = jest.fn();
         turtle0.companionTurtle = 1;
         turtle1.interval = 888;
@@ -1149,7 +1161,6 @@ describe("Logo comprehensive method coverage", () => {
         logo.processShow = jest.fn();
         logo.processSpeak = jest.fn();
         global.delayExecution = jest.fn(() => Promise.resolve());
-        if (logo.deps && logo.deps.utils) logo.deps.utils.delayExecution = global.delayExecution;
 
         turtle0.singer.suppressOutput = false;
         turtle0.embeddedGraphicsFinished = false;
@@ -1225,8 +1236,7 @@ describe("Logo comprehensive method coverage", () => {
             storage: { saveLocally: jest.fn() },
             config: { showBlocksAfterRun: false },
             callbacks: { onStopTurtle: jest.fn(), onRunTurtle: jest.fn() },
-            meSpeak: { speak: jest.fn() },
-            classes: { Notation: global.Notation, Synth: global.Synth }
+            meSpeak: { speak: jest.fn() }
         };
 
         const depLogo = new Logo(deps);

js/__tests__/logoconstants.test.js

@@ -98,8 +98,7 @@ describe("logoconstants", () => {
             "NOTATIONTUPLETVALUE",
             "NOTATIONROUNDDOWN",
             "NOTATIONINSIDECHORD",
-            "NOTATIONSTACCATO",
-            "MIN_HIGHLIGHT_DURATION_MS"
+            "NOTATIONSTACCATO"
         ];
         expect(Object.keys(constants).sort()).toEqual(expectedKeys.sort());
     });