Skip to content

Commit f488f0b

Browse files
authored
Fix missing inCrescendo.pop() in crescendo end listener (#5767)
The crescendo end listener pops crescendoDelta and crescendoInitialVolume but never pops inCrescendo, causing it to grow unboundedly and trigger spurious volume resets on subsequent notes. Signed-off-by: Ady0333 <adityashinde1525@gmail.com>
1 parent 9ae0c1b commit f488f0b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

js/turtleactions/VolumeActions.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ function setupVolumeActions(activity) {
9797
);
9898
tur.singer.crescendoInitialVolume[synth].pop();
9999
}
100+
101+
tur.singer.inCrescendo.pop();
100102
};
101103

102104
activity.logo.setTurtleListener(turtle, listenerName, __listener);

0 commit comments

Comments
 (0)