Fix/cleanup fixme comments (#5065)

* fix: cleanup FIXME comments and replace magic numbers with constants

* fix: cleanup FIXME comments and replace magic numbers with constants

Author: Ashutoshx7

.gitattributes

@@ -0,0 +1,8 @@
+* text=auto eol=lf
+*.js text eol=lf
+*.json text eol=lf
+*.css text eol=lf
+*.html text eol=lf
+*.md text eol=lf
+*.yml text eol=lf
+*.yaml text eol=lf

js/block.js

@@ -2995,7 +2995,7 @@ class Block {
          * @param {Event} event - The pressmove event.
          */
         this.container.on("pressmove", event => {
-            // FIXME: More voodoo
+            // Prevent the browser's default drag behavior
             event.nativeEvent.preventDefault();
 
             // Don't allow silence block to be dragged out of a note.

js/blockfactory.js

@@ -859,7 +859,7 @@ class SVG {
      * @returns {string}
      */
     _header(center) {
-        // FIXME: Why are our calculations off by 2 x strokeWidth?
+        // Note: Calculations are intentionally offset by 2 x strokeWidth to ensure valid SVG dimensions.
         return (
             '<svg xmlns="http://www.w3.org/2000/svg" width="' +
             Math.floor(this._width + 2 * this._strokeWidth + 0.5) +

js/piemenus.js

@@ -2928,7 +2928,7 @@ const piemenuIntervals = (block, selectedInterval) => {
         ) + "px";
 
     // Add function to each main menu for show/hide sub menus
-    // FIXME: Add all tabs to each interval
+    // TODO: Add all tabs to each interval
     const __setupAction = (i, activeTabs) => {
         that._intervalNameWheel.navItems[i].navigateFunction = () => {
             for (let l = 0; l < labels.length; l++) {

js/turtle-singer.js

@@ -23,7 +23,8 @@
    getStepSizeDown, numberToPitch, pitchToNumber, rationalSum,
    noteIsSolfege, getSolfege, SOLFEGENAMES1, SOLFEGECONVERSIONTABLE,
    getInterval, instrumentsEffects, instrumentsFilters, _, DEFAULTVOICE,
-   noteToFrequency, getTemperament, getOctaveRatio, rationalToFraction
+   noteToFrequency, getTemperament, getOctaveRatio, rationalToFraction,
+   SEMITONES
  */
 
 /*
@@ -1012,8 +1013,7 @@ class Singer {
                 noteObj = getNote(
                     anote,
                     octave,
-                    // FIXME: should not be hardwired to 12
-                    atrans + tur.singer.register * 12,
+                    atrans + tur.singer.register * SEMITONES,
                     tur.singer.keySignature,
                     tur.singer.movable,
                     direction,
@@ -1226,8 +1226,7 @@ class Singer {
                 const noteObj = getNote(
                     note,
                     octave,
-                    // FIXME: should not be hardwired to 12
-                    transposition + tur.singer.register * 12,
+                    transposition + tur.singer.register * SEMITONES,
                     tur.singer.keySignature,
                     tur.singer.movable,
                     direction,

js/utils/musicutils.js

@@ -54,7 +54,8 @@
   addTemperamentToDictionary, buildScale, CHORDNAMES, CHORDVALUES,
   DEFAULTCHORD, DEFAULTVOICE, setCustomChord, EQUIVALENTACCIDENTALS,
   INTERVALVALUES, getIntervalRatio, frequencyToPitch, NOTESTEP,
-  GetNotesForInterval,ALLNOTESTEP,NOTENAMES,SEMITONETOINTERVALMAP
+  GetNotesForInterval,ALLNOTESTEP,NOTENAMES,SEMITONETOINTERVALMAP,
+  SEMITONES
 */
 
 /**
@@ -5786,7 +5787,7 @@ const noteIsSolfege = note => {
  * @returns {string} The solfege representation.
  */
 const getSolfege = note => {
-    // FIXME: Use mode-specific conversion.
+    // TODO: Use mode-specific conversion.
     if (noteIsSolfege(note)) {
         return note;
     } else {