Pitch Number, Set Key, and Nth Modal Pitch integration for Temperament

[pikurasa]

Current Behavior

The Custom Pitch block generated when creating a custom temperament works well. However, as of now, the user is not able to leverage other helpful features when in a custom temperament.

Desired Behavior

I've identified three main places for improvement. They are:

• Integration with "Define Mode" using "Pitch Number"
• Integration with "Nth Modal Pitch"
• Integration with "Scalar Step"

Screenshots / Mockups

Here's a video of a test:
Temperament-Scale.webm

A testing file (the same one used in the video):
Temperament-Scale-Modal.zip

In the video, you see an error for setting "define mode" with a temperament system of 31 pitches. We need to rethink this design. Perhaps we allow any whole number, but we run a Mod-[number-of-pitches-in-temperament-system] on the number?

Temperament-Focus-on-various.zip

Implementation

I propose:

• We allow for any whole numbers to be input via "Pitch Number" into "Define Mode", and we run mod math via whatever the cardinality of the temperament system is.
• A new block called "temperament length" that outputs the cardinality of the temperament. So if there are 12 pitches in the current temperament, it returns 12. If there are 31, then it returns 31, etc.
• We map the defined modal pitches to the specified numeric pitch classes that the user has defined via "define mode".
• I assume this will be enough for both Nth Modal pitch and Scalar Step to work, but there may be some polishing to do.

Acceptance Tests

We can use the attached MB files to help us test the behavior.

[omsuneri]

@pikurasa seems it is the big enhancement feature change i wiil work on it clear me more about this in 10/13 MB biweekly meeting