Bug: Switching between light and dark mode causes a full-page reload instead of applying the theme instantly

[aniket866]

Description

Switching between light and dark mode causes a full-page reload instead of applying the theme instantly.

Expected Behavior

The theme should switch seamlessly without requiring a full-page reload.

Screenshots/Screen-recordings

screen-capture.1.webm

How to Reproduce

1. Open the application.
2. Navigate to the theme switcher.
3. Toggle between light and dark mode.
4. Observe that the entire application reloads instead of instantly applying the new theme.

Console log Errors:

N/A

Environment:

• Operating System: [e.g., Windows, macOS, Linux]
• Browser (if applicable): [e.g., Chrome, Firefox, Safari]
• Version of Software/Project: [e.g., v1.0.0]

Checklist

• I have read and followed the project's code of conduct.
• I have searched for similar issues before creating this one.
• I have provided all the necessary information to understand and reproduce the issue.
• I am willing to contribute to the resolution of this issue.

---

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

[farhan-momin]

Hey @aniket866 , I'm not sure why I'm mentioned in this issue. Could you provide some context?

[aniket866]

Hey @aniket866 , I'm not sure why I'm mentioned in this issue. Could you provide some context?

@farhan-momin Sorry for that , I am new here on Github, could you please tell me whom should i tag the Issues here?

[farhan-momin]

@aniket866 You can join https://matrix.to/#/#musicblocksdev:matrix.org to discuss about the issue.

[Commanderk3]

@aniket866 I am curious why do you think it's a bug?
This is intended behaviour.
Maybe you can work to make it instant.

[aniket866]

@aniket866 I am curious why do you think it's a bug? This is intended behaviour. Maybe you can work to make it instant.

@Commanderk3 this actually looks like a bug , you can see the provided video ,what if we can able to implement a toggle switch which changes theme instantly without such delay or something?

[omsuneri]

@aniket866 this is actually not an issue or bug but the functionality of music blocks like we have 2 type of components with 2 type of styling as internal and external css so if you try to refactor the theme only the thing which you can render at the real time is only the aux menu and toolbar which lies in the external css also for internal css we need to refresh the page and if you want to convert the internal css to external css such that to change the complete component to re-render in real time you need to rewrite the complete internal with a new logic using the variables of css into external to get this feature but as per the past discussion with the community we came with that this issue is not at very high priority cause the same type of behaviour is there with the advance mode and beginner mode switching also with the language too... also i had worked on this can you can refer this PR #4339

[aniket866]

@walterbender @omsuneri
I just want to show you that this feature can be improved , Recently i have worked on a project and implemented this feature there so i can improve this project too, If i get assigned . here is the video that i actually want to be in this application too.

screen-capture.4.webm

[omsuneri]

@aniket866 I just explained you the challenges you will get while doing these changes and we have this as low priority if you can do thats fine and we don't assign issues you can simply comment on a issue that you are interested to work and can raise pr for the same

[walterbender]

There are still some issues with the grid in Dark Mode. Would be better to complete Dark Mode before making it more efficient.