fix: reset temperament state on each run#5957
Open
Ady0333 wants to merge 1 commit intosugarlabs:masterfrom
Open
fix: reset temperament state on each run#5957Ady0333 wants to merge 1 commit intosugarlabs:masterfrom
Ady0333 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Signed-off-by: Ady0333 <adityashinde1525@gmail.com>
Contributor
Author
|
@walterbender, @omsuneri and @vanshika2720 . Please review this pr once |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
vanshika2720
approved these changes
Mar 1, 2026
Contributor
There was a problem hiding this comment.
@Ady0333 The logic is correct and solves the state-leak problem.
However, from a design perspective, this would be stronger if:
- Defaults were derived from the original initialization logic, or
- A single reset method handled temperament state cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: reset temperament state in runLogoCommands to prevent frequency corruption across runs
When a program uses Set Temperament, the temperament state persists into subsequent runs even after removing the block. This causes silent pitch corruption where notes play at wrong frequencies.
Root cause:
runLogoCommands()resetschangeInTemperamentbut notinTemperament,startingPitch, ornoteFrequencies. With the flag false and temperament still set,_getFrequency()uses the stale lookup table.Fix: Reset all three properties alongside existing BPM resets: