maybe work-around crash in PrintFile()

kjk · kjk · commit 08a386b72947 · 2022-06-04T16:23:50.000-04:00
diff --git a/src/Print.cpp b/src/Print.cpp
@@ -1214,7 +1214,11 @@ bool PrintFile(EngineBase* engine, WCHAR* printerName, bool displayErrors, const
         }
     }
 
-    delete printer;
+    // TODO: I saw a crash in crash report where we crash inside ~Printer
+    // in str::Free(name)
+    // I can't see why this could happen but maybe it's just a random memory corruption
+    // if it's memory corruption then we'll crash anyway
+    // delete printer;
     return ok;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1214,7 +1214,11 @@ bool PrintFile(EngineBase* engine, WCHAR* printerName, bool displayErrors, const`
`1214`	`1214`	`}`
`1215`	`1215`	`}`
`1216`	`1216`
`1217`		`- delete printer;`
	`1217`	`+ // TODO: I saw a crash in crash report where we crash inside ~Printer`
	`1218`	`+ // in str::Free(name)`
	`1219`	`+ // I can't see why this could happen but maybe it's just a random memory corruption`
	`1220`	`+ // if it's memory corruption then we'll crash anyway`
	`1221`	`+ // delete printer;`
`1218`	`1222`	`return ok;`
`1219`	`1223`	`}`
`1220`	`1224`