Skip to content

Commit cff7097

Browse files
committed
sign when building locally
1 parent 39e2529 commit cff7097

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

do/upload_s3.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,18 @@ const (
1616
maxS3Results = 1000
1717
)
1818

19-
// we should only sign and upload to s3 if this is my repo
20-
// and a push event
19+
// we should only sign and upload to s3 if this is my repo and a push event
20+
// or building locally
21+
// don't sign if it's a fork or pull requests
2122
func shouldSignAndUpload() bool {
2223
// https://help.github.com/en/actions/automating-your-workflow-with-github-actions/using-environment-variables
2324

2425
repo := os.Getenv("GITHUB_REPOSITORY")
26+
if repo == "" {
27+
// building locally e.g. release for final testing
28+
// we want to sign it
29+
return true
30+
}
2531
if repo != "sumatrapdfreader/sumatrapdf" {
2632
return false
2733
}

0 commit comments

Comments
 (0)