Why .json.gz?

[mbbush]

The way the code works, the card db data is stored twice; once in card_db_src in .json format, and again, compressed, inside the src/domdiv folder.

What I'm wondering is what advantage that provides over simply reading the .json from card_db_src, and whether you'd be open to switching (back?) to that simpler approach.

I'm envisioning something like this:

• Scripts (which I have mostly done) to generate the necessary source files by reading from the dominion strategy wiki. The only piece of data this doesn't have is the non-english "extra" rules.
• A github actions job which runs the scripts on some cadence (weekly?) and opens a pull request if there are changes, to keep things up to date. This is the sort of automation I've built at my day job.

But I really don't see an advantage to having an extra gzip step in this pipeline.

What do you think?

[sumpfork]

They used to be in one place an uncompressed, and contributors got very lost because the files would update from under them (we add all the non-translated en-us content where translations aren't available) and conflicts would arise all the time, making people abandon contribution efforts even more than they do now. Then I separated "src" and modified packaged files so that it was clearer what would be changed without even being able to produce the files actually read by the script. Then contributors still got lost, so I gzipped the target files mainly so that it was clear that these shouldn't be directly edited.

I haven't checked the completeness of Dominion Strategy, but if we can really get everything from there and just slurp it up, great. Sounds like at minimum we still need to keep some translations for the 'extra' sections and merge them?

So yeah, current setup is mainly for contributors, but it's still not simple for folks who aren't familiar with github, python, etc. If we can have a greatly reduced need for contributors because we're getting most things from Dominion Strategy and just maintain a bit of extra translation, automate integration with Dominion Strategy: great.

[sumpfork]

Also, thanks so much for taking the time to audit all of this. I have other projects ongoing (https://github.com/sumpfork/seas_of_havoc_boardgamearena), but I'll try to stay semi-on-the-ball with your changes.