Skip to content

Commit 4688fa5

Browse files
committed
remove superfluous aria-haspopup attribute from Popover component
1 parent 6281a89 commit 4688fa5

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.changeset/five-schools-sit.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@sumup-oss/circuit-ui": patch
3+
---
4+
5+
Removed the superfluous `aria-haspopup` attribute from the Popover's trigger element.

packages/circuit-ui/components/Popover/Popover.tsx

-2
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ export interface PopoverProps {
161161
'onClick': (event: ClickEvent) => void;
162162
'onKeyDown': (event: KeyboardEvent) => void;
163163
'id': string;
164-
'aria-haspopup': boolean;
165164
'aria-controls': string;
166165
'aria-expanded': boolean;
167166
}) => React.JSX.Element;
@@ -322,7 +321,6 @@ export const Popover = ({
322321
<div className={classes.trigger} ref={refs.setReference}>
323322
<Component
324323
id={triggerId}
325-
aria-haspopup={true}
326324
aria-controls={menuId}
327325
aria-expanded={isOpen}
328326
onClick={handleTriggerClick}

0 commit comments

Comments
 (0)