Skip to content

Commit 3e3bffa

Browse files
committed
validation improvements: added more conditional validation, checking for mech and pointp params, implemented user-friendly messages
1 parent a1068e5 commit 3e3bffa

File tree

4 files changed

+555
-469
lines changed

4 files changed

+555
-469
lines changed

netpyne/network/network.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def __init__(self, params=None):
2626
self.connStringFuncParams = ['weight', 'delay', 'synsPerConn', 'loc']
2727

2828
# params that can be expressed using string-based functions in stims
29-
self.stimStringFuncParams = [
29+
self.stimStringFuncParams = [ # TODO: why this limited list and not all possible params for custom stims?
3030
'del',
3131
'dur',
3232
'amp',

netpyne/sim/setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,9 @@ def initialize(netParams=None, simConfig=None, net=None):
9898
if failed:
9999
failedComps = [err.component for err in failed] # get failed component name
100100
failedComps = list(set(failedComps)) # keep unique elements only
101-
print(f"\nNetParams validation identified some potential issues in {', '.join(failedComps)}. See above for details.")
101+
print(f"\n✋ NetParams validation identified some potential issues in {', '.join(failedComps)}. See above for details.")
102102
else:
103-
print("\nNetParams validation successful.")
103+
print("\n✅ NetParams validation successful.")
104104
except Exception as e:
105105
sim.timing('stop', 'validationTime')
106106
print("\nAn exception occurred during the netParams validation process.")

0 commit comments

Comments
 (0)