fix: refreshing tokens at the wrong time (#55)

MilesV64 · web-flow · commit a972c99bf0ed · 2023-05-03T07:44:03.000+02:00
* fix: refreshing tokens at the wrong time StoredSession.isValid was being calculated incorrectly, because by comparing to "1 minute ago", it means an access token which expires "30 seconds ago" is still valid for 30 seconds. Changing to plus 60 seconds eliminates this problem, and bakes in plenty of time for latency issues. In a future evolution I believe this value should be configurable. * configurable refresh tolerance * Revert "configurable refresh tolerance" This reverts commit 942acce.
diff --git a/Sources/GoTrue/Internal/SessionManager.swift b/Sources/GoTrue/Internal/SessionManager.swift
@@ -6,7 +6,7 @@ struct StoredSession: Codable {
   var expirationDate: Date
 
   var isValid: Bool {
-    expirationDate > Date().addingTimeInterval(-60)
+    expirationDate > Date().addingTimeInterval(60)
   }
 
   init(session: Session, expirationDate: Date? = nil) {

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ struct StoredSession: Codable {`
`6`	`6`	`var expirationDate: Date`
`7`	`7`
`8`	`8`	`var isValid: Bool {`
`9`		`- expirationDate > Date().addingTimeInterval(-60)`
	`9`	`+ expirationDate > Date().addingTimeInterval(60)`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`init(session: Session, expirationDate: Date? = nil) {`