Skip to content

Commit ccbec67

Browse files
authored
Merge pull request #13 from supabase/feature/query-param-callback
fix: changes # to ? in external redirect callbacks
2 parents ac0ea02 + 9ec992d commit ccbec67

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

api/external.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ func (a *API) internalExternalProviderCallback(w http.ResponseWriter, r *http.Re
212212
q.Set("token_type", token.TokenType)
213213
q.Set("expires_in", strconv.Itoa(token.ExpiresIn))
214214
q.Set("refresh_token", token.RefreshToken)
215-
rurl += "#" + q.Encode()
215+
rurl += "?" + q.Encode()
216216
}
217217
http.Redirect(w, r, rurl, http.StatusFound)
218218
return nil
@@ -322,7 +322,7 @@ func (a *API) redirectErrors(handler apiHandler, w http.ResponseWriter, r *http.
322322
err := handler(w, r)
323323
if err != nil {
324324
q := getErrorQueryString(err, errorID, log)
325-
http.Redirect(w, r, a.getExternalRedirectURL(r)+"#"+q.Encode(), http.StatusFound)
325+
http.Redirect(w, r, a.getExternalRedirectURL(r)+"?"+q.Encode(), http.StatusFound)
326326
}
327327
}
328328

0 commit comments

Comments
 (0)