fix: improve saml assertion logging (#1915)

kangmingtay · web-flow · commit d6030ccd271a · 2025-01-22T09:59:56.000+01:00
## What kind of change does this PR introduce?
* Logs the `Response` returned from the library as well
diff --git a/internal/api/samlacs.go b/internal/api/samlacs.go
@@ -189,7 +189,7 @@ func (a *API) handleSamlAcs(w http.ResponseWriter, r *http.Request) error {
 	spAssertion, err := serviceProvider.ParseResponse(r, requestIds)
 	if err != nil {
 		if ire, ok := err.(*saml.InvalidResponseError); ok {
-			return badRequestError(ErrorCodeValidationFailed, "SAML Assertion is not valid").WithInternalError(ire.PrivateErr)
+			return badRequestError(ErrorCodeValidationFailed, "SAML Assertion is not valid %s", ire.Response).WithInternalError(ire.PrivateErr)
 		}
 
 		return badRequestError(ErrorCodeValidationFailed, "SAML Assertion is not valid").WithInternalError(err)

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ func (a API) handleSamlAcs(w http.ResponseWriter, r http.Request) error {`
`189`	`189`	`spAssertion, err := serviceProvider.ParseResponse(r, requestIds)`
`190`	`190`	`if err != nil {`
`191`	`191`	`if ire, ok := err.(*saml.InvalidResponseError); ok {`
`192`		`- return badRequestError(ErrorCodeValidationFailed, "SAML Assertion is not valid").WithInternalError(ire.PrivateErr)`
	`192`	`+ return badRequestError(ErrorCodeValidationFailed, "SAML Assertion is not valid %s", ire.Response).WithInternalError(ire.PrivateErr)`
`193`	`193`	`}`
`194`	`194`
`195`	`195`	`return badRequestError(ErrorCodeValidationFailed, "SAML Assertion is not valid").WithInternalError(err)`