fix: use correct format for last modified date header (#192)

Author: ikhsan

src/routes/object/getObject.ts

@@ -92,7 +92,7 @@ async function requestHandler(
       .header('Cache-Control', data.metadata.cacheControl)
       .header('ETag', data.metadata.eTag)
       .header('Content-Length', data.metadata.contentLength)
-      .header('Last-Modified', data.metadata.lastModified)
+      .header('Last-Modified', data.metadata.lastModified?.toUTCString())
     if (data.metadata.contentRange) {
       response.header('Content-Range', data.metadata.contentRange)
     }

src/routes/object/getPublicObject.ts

@@ -87,7 +87,7 @@ export default async function routes(fastify: FastifyInstance) {
           .header('Cache-Control', data.metadata.cacheControl)
           .header('Content-Length', data.metadata.contentLength)
           .header('ETag', data.metadata.eTag)
-          .header('Last-Modified', data.metadata.lastModified)
+          .header('Last-Modified', data.metadata.lastModified?.toUTCString())
         if (data.metadata.contentRange) {
           response.header('Content-Range', data.metadata.contentRange)
         }

src/routes/object/getSignedObject.ts

@@ -87,7 +87,7 @@ export default async function routes(fastify: FastifyInstance) {
           .header('Cache-Control', data.metadata.cacheControl)
           .header('Content-Length', data.metadata.contentLength)
           .header('ETag', data.metadata.eTag)
-          .header('Last-Modified', data.metadata.lastModified)
+          .header('Last-Modified', data.metadata.lastModified?.toUTCString())
         if (data.metadata.contentRange) {
           response.header('Content-Range', data.metadata.contentRange)
         }

src/test/bucket.test.ts

@@ -18,6 +18,8 @@ beforeAll(() => {
         httpStatusCode: 200,
         size: 3746,
         mimetype: 'image/png',
+        lastModified: new Date('Thu, 12 Aug 2021 16:00:00 GMT'),
+        eTag: 'abc',
       },
       body: Buffer.from(''),
     })
@@ -202,6 +204,8 @@ describe('testing public bucket functionality', () => {
       url: `/object/public/public-bucket/favicon.ico`,
     })
     expect(publicResponse.statusCode).toBe(200)
+    expect(publicResponse.headers['etag']).toBe('abc')
+    expect(publicResponse.headers['last-modified']).toBe('Thu, 12 Aug 2021 16:00:00 GMT')
 
     const mockGetObject = jest.spyOn(S3Backend.prototype, 'getObject')
     mockGetObject.mockRejectedValue({
@@ -213,13 +217,13 @@ describe('testing public bucket functionality', () => {
       method: 'GET',
       url: `/object/public/public-bucket/favicon.ico`,
       headers: {
-        'if-modified-since': 'Fri Aug 13 2021 00:00:00 GMT+0800 (Singapore Standard Time)',
+        'if-modified-since': 'Thu, 12 Aug 2021 16:00:00 GMT',
         'if-none-match': 'abc',
       },
     })
     expect(notModifiedResponse.statusCode).toBe(304)
     expect(mockGetObject.mock.calls[1][2]).toMatchObject({
-      ifModifiedSince: 'Fri Aug 13 2021 00:00:00 GMT+0800 (Singapore Standard Time)',
+      ifModifiedSince: 'Thu, 12 Aug 2021 16:00:00 GMT',
       ifNoneMatch: 'abc',
     })
 

src/test/object.test.ts

@@ -32,6 +32,8 @@ beforeEach(() => {
       httpStatusCode: 200,
       size: 3746,
       mimetype: 'image/png',
+      lastModified: new Date('Thu, 12 Aug 2021 16:00:00 GMT'),
+      eTag: 'abc',
     },
     body: Buffer.from(''),
   })
@@ -76,6 +78,8 @@ describe('testing GET object', () => {
       },
     })
     expect(response.statusCode).toBe(200)
+    expect(response.headers['etag']).toBe('abc')
+    expect(response.headers['last-modified']).toBe('Thu, 12 Aug 2021 16:00:00 GMT')
     expect(S3Backend.prototype.getObject).toBeCalled()
   })
 
@@ -91,13 +95,13 @@ describe('testing GET object', () => {
       url: '/object/authenticated/bucket2/authenticated/casestudy.png',
       headers: {
         authorization: `Bearer ${process.env.AUTHENTICATED_KEY}`,
-        'if-modified-since': 'Fri Aug 13 2021 00:00:00 GMT+0800 (Singapore Standard Time)',
+        'if-modified-since': 'Thu, 12 Aug 2021 16:00:00 GMT',
         'if-none-match': 'abc',
       },
     })
     expect(response.statusCode).toBe(304)
     expect(mockGetObject.mock.calls[0][2]).toMatchObject({
-      ifModifiedSince: 'Fri Aug 13 2021 00:00:00 GMT+0800 (Singapore Standard Time)',
+      ifModifiedSince: 'Thu, 12 Aug 2021 16:00:00 GMT',
       ifNoneMatch: 'abc',
     })
   })
@@ -1246,6 +1250,8 @@ describe('testing retrieving signed URL', () => {
       url: `/object/sign/${urlToSign}?token=${jwtToken}`,
     })
     expect(response.statusCode).toBe(200)
+    expect(response.headers['etag']).toBe('abc')
+    expect(response.headers['last-modified']).toBe('Thu, 12 Aug 2021 16:00:00 GMT')
   })
 
   test('forward 304 and If-Modified-Since/If-None-Match headers', async () => {
@@ -1261,13 +1267,13 @@ describe('testing retrieving signed URL', () => {
       method: 'GET',
       url: `/object/sign/${urlToSign}?token=${jwtToken}`,
       headers: {
-        'if-modified-since': 'Fri Aug 13 2021 00:00:00 GMT+0800 (Singapore Standard Time)',
+        'if-modified-since': 'Thu, 12 Aug 2021 16:00:00 GMT',
         'if-none-match': 'abc',
       },
     })
     expect(response.statusCode).toBe(304)
     expect(mockGetObject.mock.calls[0][2]).toMatchObject({
-      ifModifiedSince: 'Fri Aug 13 2021 00:00:00 GMT+0800 (Singapore Standard Time)',
+      ifModifiedSince: 'Thu, 12 Aug 2021 16:00:00 GMT',
       ifNoneMatch: 'abc',
     })
   })