tests for public buckets

Author: inian

src/routes/object/getPublicObject.ts

@@ -22,7 +22,7 @@ interface getObjectRequestInterface {
 
 // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export default async function routes(fastify: FastifyInstance) {
-  const summary = 'Retrieve an object'
+  const summary = 'Retrieve a public object'
   fastify.get<getObjectRequestInterface>(
     '/public/:bucketName/*',
     {

src/test/bucket.test.ts

@@ -7,7 +7,7 @@ import * as utils from '../utils/s3'
 dotenv.config({ path: '.env.test' })
 const { anonKey } = getConfig()
 
-let mockDeleteObjects: any
+let mockDeleteObjects: any, mockGetObject: any
 
 beforeAll(() => {
   mockDeleteObjects = jest.spyOn(utils, 'deleteObjects')
@@ -18,6 +18,20 @@ beforeAll(() => {
       },
     })
   )
+  mockGetObject = jest.spyOn(utils, 'getObject')
+  mockGetObject.mockImplementation(() =>
+    Promise.resolve({
+      $metadata: {
+        httpStatusCode: 200,
+      },
+      CacheControl: undefined,
+      ContentDisposition: undefined,
+      ContentEncoding: undefined,
+      ContentLength: 3746,
+      ContentType: 'image/png',
+      Metadata: {},
+    })
+  )
 })
 
 beforeEach(() => {
@@ -89,7 +103,7 @@ describe('testing GET all buckets', () => {
     })
     expect(response.statusCode).toBe(200)
     const responseJSON = JSON.parse(response.body)
-    expect(responseJSON.length).toBe(4)
+    expect(responseJSON.length).toBe(5)
   })
 
   test('checking RLS: anon user is not able to get all buckets', async () => {
@@ -173,6 +187,93 @@ describe('testing POST bucket', () => {
   })
 })
 
+/*
+ * PUT /bucket
+ */
+describe('testing public bucket functionality', () => {
+  test('user is able to make a bucket public and private', async () => {
+    const bucketId = 'public-bucket'
+    const makePublicResponse = await app().inject({
+      method: 'PUT',
+      url: `/bucket/${bucketId}`,
+      headers: {
+        authorization: `Bearer ${process.env.AUTHENTICATED_KEY}`,
+      },
+      payload: {
+        public: true,
+      },
+    })
+    expect(makePublicResponse.statusCode).toBe(200)
+    const makePublicJSON = JSON.parse(makePublicResponse.body)
+    expect(makePublicJSON.message).toBe('Successfully updated')
+
+    const publicResponse = await app().inject({
+      method: 'GET',
+      url: `/object/public/public-bucket/favicon.ico`,
+    })
+    expect(publicResponse.statusCode).toBe(200)
+
+    const makePrivateResponse = await app().inject({
+      method: 'PUT',
+      url: `/bucket/${bucketId}`,
+      headers: {
+        authorization: `Bearer ${process.env.AUTHENTICATED_KEY}`,
+      },
+      payload: {
+        public: false,
+      },
+    })
+    expect(makePrivateResponse.statusCode).toBe(200)
+    const makePrivateJSON = JSON.parse(makePrivateResponse.body)
+    expect(makePrivateJSON.message).toBe('Successfully updated')
+
+    const privateResponse = await app().inject({
+      method: 'GET',
+      url: `/object/public/public-bucket/favicon.ico`,
+    })
+    expect(privateResponse.statusCode).toBe(400)
+  })
+
+  test('checking RLS: anon user is not able to update a bucket', async () => {
+    const bucketId = 'public-bucket'
+    const response = await app().inject({
+      method: 'PUT',
+      url: `/bucket/${bucketId}`,
+      headers: {
+        authorization: `Bearer ${anonKey}`,
+      },
+      payload: {
+        public: true,
+      },
+    })
+    expect(response.statusCode).toBe(400)
+  })
+
+  test('user is not able to update a bucket without a auth header', async () => {
+    const bucketId = 'public-bucket'
+    const response = await app().inject({
+      method: 'PUT',
+      url: `/bucket/${bucketId}`,
+      payload: {
+        public: true,
+      },
+    })
+    expect(response.statusCode).toBe(400)
+  })
+
+  test('user is not able to update a non-existent bucket', async () => {
+    const bucketId = 'notfound'
+    const response = await app().inject({
+      method: 'PUT',
+      url: `/bucket/${bucketId}`,
+      payload: {
+        public: true,
+      },
+    })
+    expect(response.statusCode).toBe(400)
+  })
+})
+
 describe('testing DELETE bucket', () => {
   test('user is able to delete a bucket', async () => {
     const bucketId = 'bucket4'

src/test/db/03-dummy-data.sql

@@ -9,7 +9,8 @@ INSERT INTO "storage"."buckets" ("id", "name", "owner", "created_at", "updated_a
 ('bucket2', 'bucket2', '4d56e902-f0a0-4662-8448-a4d9e643c142', '2021-02-17 04:43:32.770206+00', '2021-02-17 04:43:32.770206+00'),
 ('bucket3', 'bucket3', '4d56e902-f0a0-4662-8448-a4d9e643c142', '2021-02-17 04:43:32.770206+00', '2021-02-17 04:43:32.770206+00'),
 ('bucket4', 'bucket4', '317eadce-631a-4429-a0bb-f19a7a517b4a', '2021-02-25 09:23:01.58385+00', '2021-02-25 09:23:01.58385+00'),
-('bucket5', 'bucket5', '317eadce-631a-4429-a0bb-f19a7a517b4a', '2021-02-27 03:04:25.6386+00', '2021-02-27 03:04:25.6386+00');
+('bucket5', 'bucket5', '317eadce-631a-4429-a0bb-f19a7a517b4a', '2021-02-27 03:04:25.6386+00', '2021-02-27 03:04:25.6386+00'),
+('public-bucket', 'public-bucket', '317eadce-631a-4429-a0bb-f19a7a517b4a', '2021-02-27 03:04:25.6386+00', '2021-02-27 03:04:25.6386+00');
 
 
 -- insert objects
@@ -33,7 +34,9 @@ INSERT INTO "storage"."objects" ("id", "bucket_id", "name", "owner", "created_at
 ('8377527d-3518-4dc8-8290-c6926470e795', 'bucket2', 'folder/subfolder/public-all-permissions.png', 'd8c7bce9-cfeb-497b-bd61-e66ce2cbdaa2', '2021-02-17 10:26:42.791214+00', '2021-02-17 11:03:30.025116+00', '2021-02-17 10:26:42.791214+00', '{"size": 1234}'),
 ('b39ae4ab-802b-4c42-9271-3f908c34363c', 'bucket2', 'private/sadcat-upload3.png', '317eadce-631a-4429-a0bb-f19a7a517b4a', '2021-03-01 08:53:29.567975+00', '2021-03-01 08:53:29.567975+00', '2021-03-01 08:53:29.567975+00', '{"mimetype": "image/svg+xml", "size": 1234}'),
 ('8098E1AC-C744-4368-86DF-71B60CCDE221', 'bucket3', 'sadcat-upload3.png', '317eadce-631a-4429-a0bb-f19a7a517b4a', '2021-03-01 08:53:29.567975+00', '2021-03-01 08:53:29.567975+00', '2021-03-01 08:53:29.567975+00', '{"mimetype": "image/svg+xml", "size": 1234}'),
-('D3EB488E-94F4-46CD-86D3-242C13B95BAC', 'bucket3', 'sadcat-upload2.png', '317eadce-631a-4429-a0bb-f19a7a517b4a', '2021-03-01 08:53:29.567975+00', '2021-03-01 08:53:29.567975+00', '2021-03-01 08:53:29.567975+00', '{"mimetype": "image/svg+xml", "size": 1234}');
+('D3EB488E-94F4-46CD-86D3-242C13B95BAC', 'bucket3', 'sadcat-upload2.png', '317eadce-631a-4429-a0bb-f19a7a517b4a', '2021-03-01 08:53:29.567975+00', '2021-03-01 08:53:29.567975+00', '2021-03-01 08:53:29.567975+00', '{"mimetype": "image/svg+xml", "size": 1234}'),
+('746180e8-8029-4134-8a21-48ab35485d81', 'public-bucket', 'favicon.ico', '317eadce-631a-4429-a0bb-f19a7a517b4a', '2021-03-01 08:53:29.567975+00', '2021-03-01 08:53:29.567975+00', '2021-03-01 08:53:29.567975+00', '{"mimetype": "image/svg+xml", "size": 1234}');
+;
 
 -- add policies
 -- allows user to CRUD all buckets

src/test/object.test.ts

@@ -659,6 +659,11 @@ describe('testing generating signed URL', () => {
   })
 })
 
+/**
+ * GET /public/
+ */
+// these tests are written in bucket.test.ts since its easier
+
 /**
  * GET /sign/
  */