fix: acquire with signal tests

Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>

Author: ferhatelmas

src/test/pg-connection.test.ts

@@ -29,9 +29,9 @@ describe('Pg database foundation', () => {
     }
   }
 
-  async function createConnection() {
+  async function createConnection(overrides?: Partial<TenantConnectionOptions>) {
     const superUser = await getServiceKeyUser(tenantId)
-    const settings = createConnectionSettings(superUser)
+    const settings = createConnectionSettings(superUser, overrides)
 
     const pool = new PgPoolStrategy(settings)
     const connection = new PgTenantConnection(pool, settings)
@@ -206,6 +206,68 @@ describe('Pg database foundation', () => {
     }
   })
 
+  it('releases the pending client unused when acquisition is aborted on an exhausted pool', async () => {
+    const { pool } = await createConnection({ maxConnections: 1 })
+
+    try {
+      const holder = await pool.acquire().beginTransaction()
+
+      try {
+        const controller = new AbortController()
+        const pending = pool.acquire().beginTransaction({ signal: controller.signal })
+        controller.abort()
+
+        await expect(pending).rejects.toMatchObject({
+          name: 'AbortError',
+          code: 'ABORT_ERR',
+          message: 'Query was aborted',
+        })
+
+        expect(pool.getPoolStats()).toEqual({ total: 1, used: 1 })
+      } finally {
+        await holder.rollback()
+      }
+
+      await new Promise((resolve) => setImmediate(resolve))
+      expect(pool.getPoolStats()).toEqual({ total: 1, used: 0 })
+
+      const result = await pool.acquire().query<{ n: number }>('SELECT 1 AS n')
+      expect(result.rows[0].n).toBe(1)
+      expect(pool.getPoolStats()).toEqual({ total: 1, used: 0 })
+    } finally {
+      await pool.destroy()
+    }
+  })
+
+  it('destroys the client instead of returning it to the pool when a query is aborted mid-flight', async () => {
+    const { pool } = await createConnection()
+    const controller = new AbortController()
+
+    try {
+      const query = pool.acquire().query('SELECT pg_sleep(10)', {
+        signal: controller.signal,
+      })
+      const abortTimeout = setTimeout(() => controller.abort(), 50)
+
+      try {
+        await expect(query).rejects.toMatchObject({
+          name: 'AbortError',
+          code: 'ABORT_ERR',
+        })
+      } finally {
+        clearTimeout(abortTimeout)
+      }
+
+      expect(pool.getPoolStats()).toEqual({ total: 0, used: 0 })
+
+      const result = await pool.acquire().query<{ n: number }>('SELECT 1 AS n')
+      expect(result.rows[0].n).toBe(1)
+      expect(pool.getPoolStats()).toEqual({ total: 1, used: 0 })
+    } finally {
+      await pool.destroy()
+    }
+  })
+
   it('reuses cached pg tenant pools for cacheable settings', async () => {
     const superUser = await getServiceKeyUser(tenantId)
     const settings = createConnectionSettings(superUser, {